Skip to content

🐛 Nmap parser: Add url info to description #12411 #12466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: bugfix
Choose a base branch
from

Conversation

manuel-sommer
Copy link
Contributor

Copy link

dryrunsecurity bot commented May 16, 2025

DryRun Security

No security concerns detected in this pull request.


All finding details can be found in the DryRun Security Dashboard.

@valentijnscholten
Copy link
Member

valentijnscholten commented May 21, 2025

Thank you. I might be nitpicking, but should we just list all of the urls and use the type to classify them?
For example just show PTR: instead of FQDN? The code seems to assume the PTR record is the FQDN, but it might not be. If the user scanned "google.com" the FQDNin Defect Dojo is shown as ar10s10-in-f238.1e100.net.
This might confuse users. They would need to know the implementation details of the parser to know where the value comes from. It might be easier and more clear if the description for that google.com scan looked like this:

**IP Address:** 172.217.18.238
**PTR:** par10s10-in-f238.1e100.net
**User:** google.com
**custom:** lalala

Copy link
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per my comment (Adding this to make the review reminder bot happy :-))

Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per Vals comment (Adding this to make the review reminder bot happy :-))

@manuel-sommer
Copy link
Contributor Author

Done, sorry, was quite busy

Copy link
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, happy with all your contributions. approved :-D

@valentijnscholten valentijnscholten added this to the 2.47.2 milestone Jun 9, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch requested a review from hblankenship June 11, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants