-
Notifications
You must be signed in to change notification settings - Fork 1.7k
🐛 Nmap parser: Add url info to description #12411 #12466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bugfix
Are you sure you want to change the base?
Conversation
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
Thank you. I might be nitpicking, but should we just list all of the urls and use the type to classify them?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per my comment (Adding this to make the review reminder bot happy :-))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per Vals comment (Adding this to make the review reminder bot happy :-))
Done, sorry, was quite busy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries, happy with all your contributions. approved :-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
#12411