Skip to content

Commit 9ef5bfc

Browse files
committed
Change mac build target
- Changed `mac` build target back to `dmg` as it works with newer version of `electron-builder`. - Updated CHANGELOG.
1 parent 4b79d5e commit 9ef5bfc

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
5454
- Enabled `asar`. _(turn it off if the executable built doesn't work)_
5555
- Disabled one click installer.
5656
- Allowed custom installation directory in the installer built.
57+
- `mac`:
58+
- Changed build target back to `dmg`.
5759

5860
### Fixed
5961
- ESLint errors/warnings on `main.ts` & `renderer.tsx`.
62+
- `electron-builder` fails to build `dmg` on `macOS` (issue
63+
[electron-builder #3990])by upgrading the package version to `> 21.2.0`.
6064

6165
### Removed
6266
- NPM package `copy-pkg-json-webpack-plugin` as it doesn't work with Webpack 5
@@ -152,3 +156,4 @@ issue.
152156
[2.0.2]: https://github.com/Devtography/electron-react-typescript-webpack-boilerplate/compare/v2.0.1...v2.0.2
153157

154158
[Issue #2]: https://github.com/Devtography/electron-react-typescript-webpack-boilerplate/issues/2
159+
[electron-builder #3990]: https://github.com/electron-userland/electron-builder/issues/3990

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"output": "./out/"
2020
},
2121
"mac": {
22-
"target": "pkg"
22+
"target": "dmg"
2323
},
2424
"win": {
2525
"target": "nsis",

0 commit comments

Comments
 (0)