Run service teardown code in willDestroy() (#257)

SergeAstapov · web-flow · commit d6cc035e45a3 · 2020-08-01T14:19:54.000-07:00
* Run service teardown code in willDestroy()

* Revert super.willDestroy
diff --git a/addon/index.js b/addon/index.js
@@ -114,7 +114,7 @@ class EmberRouterScroll extends EmberRouter {
     });
   }
 
-  destroy() {
+  willDestroy() {
     reset();
 
     if (requestId) {
@@ -125,7 +125,7 @@ class EmberRouterScroll extends EmberRouter {
       window.cancelAnimationFrame(callbackRequestId);
     }
 
-    super.destroy(...arguments);
+    super.willDestroy(...arguments);
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ class EmberRouterScroll extends EmberRouter {`
`114`	`114`	`});`
`115`	`115`	`}`
`116`	`116`
`117`		`- destroy() {`
	`117`	`+ willDestroy() {`
`118`	`118`	`reset();`
`119`	`119`
`120`	`120`	`if (requestId) {`
`@@ -125,7 +125,7 @@ class EmberRouterScroll extends EmberRouter {`
`125`	`125`	`window.cancelAnimationFrame(callbackRequestId);`
`126`	`126`	`}`
`127`	`127`
`128`		`- super.destroy(...arguments);`
	`128`	`+ super.willDestroy(...arguments);`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`/**`