Skip to content

Commit c0fc156

Browse files
author
Riera Auge
committed
Merge branch 'master' into c-cate
2 parents b095e93 + b6d130a commit c0fc156

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+1407
-663
lines changed

.github/ISSUE_TEMPLATE/bug_report.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ body:
7272
```python
7373
import platform; print(platform.platform())
7474
import sys; print("Python", sys.version)
75-
import doubleml; print("DoubleML", sklearn.__version__)
75+
import doubleml; print("DoubleML", doubleml.__version__)
7676
import sklearn; print("Scikit-Learn", sklearn.__version__)
7777
```
7878
validations:

README.md

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -98,21 +98,23 @@ and our
9898

9999
If you use the DoubleML package a citation is highly appreciated:
100100

101-
Bach, P., Chernozhukov, V., Kurz, M. S., and Spindler, M. (2021), DoubleML - An
101+
Bach, P., Chernozhukov, V., Kurz, M. S., and Spindler, M. (2022), DoubleML - An
102102
Object-Oriented Implementation of Double Machine Learning in Python,
103-
arXiv:[2104.03220](https://arxiv.org/abs/2104.03220).
103+
Journal of Machine Learning Research, 23(53): 1-6,
104+
[https://www.jmlr.org/papers/v23/21-0862.html](https://www.jmlr.org/papers/v23/21-0862.html).
104105

105106
Bibtex-entry:
106107

107108
```
108-
@misc{DoubleML2021,
109-
title={{DoubleML} -- {A}n Object-Oriented Implementation of Double Machine Learning in {P}ython},
110-
author={Philipp Bach and Victor Chernozhukov and Malte S. Kurz and Martin Spindler},
111-
year={2021},
112-
eprint={2104.03220},
113-
archivePrefix={arXiv},
114-
primaryClass={stat.ML},
115-
note={arXiv:\href{https://arxiv.org/abs/2104.03220}{2104.03220} [stat.ML]}
109+
@article{DoubleML2022,
110+
title = {{DoubleML} -- {A}n Object-Oriented Implementation of Double Machine Learning in {P}ython},
111+
author = {Philipp Bach and Victor Chernozhukov and Malte S. Kurz and Martin Spindler},
112+
journal = {Journal of Machine Learning Research},
113+
year = {2022},
114+
volume = {23},
115+
number = {53},
116+
pages = {1--6},
117+
url = {http://jmlr.org/papers/v23/21-0862.html}
116118
}
117119
```
118120

doc/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
author = 'Bach, P., Chernozhukov, V., Kurz, M. S., and Spindler, M.'
2323

2424
# The full version, including alpha/beta/rc tags
25-
release = '0.2.dev0'
25+
release = '0.5.dev0'
2626

2727

2828
# -- General configuration ---------------------------------------------------

doubleml/datasets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def fetch_bonus(return_type='DoubleMLData', polynomial_features=False):
104104
if polynomial_features:
105105
poly = PolynomialFeatures(2, include_bias=False)
106106
data_transf = poly.fit_transform(data[x_cols])
107-
x_cols = poly.get_feature_names(x_cols)
107+
x_cols = list(poly.get_feature_names_out(x_cols))
108108

109109
data_transf = pd.DataFrame(data_transf, columns=x_cols)
110110
data = pd.concat((data[[y_col] + d_cols], data_transf),

doubleml/double_ml_iivm.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,9 @@ def _score_elements(self, y, z, d, g_hat0, g_hat1, m_hat, r_hat0, r_hat1, smpls)
308308
- np.divide(np.multiply(1.0-z, w_hat0), 1.0 - m_hat))
309309
else:
310310
assert callable(self.score)
311-
psi_a, psi_b = self.score(y, z, d, g_hat0, g_hat1, m_hat, r_hat0, r_hat1, smpls)
311+
psi_a, psi_b = self.score(y=y, z=z, d=d,
312+
g_hat0=g_hat0, g_hat1=g_hat1, m_hat=m_hat, r_hat0=r_hat0, r_hat1=r_hat1,
313+
smpls=smpls)
312314

313315
return psi_a, psi_b
314316

doubleml/double_ml_irm.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,9 @@ def _score_elements(self, y, d, g_hat0, g_hat1, m_hat, smpls):
404404
psi_a = - np.divide(d, p_hat)
405405
else:
406406
assert callable(self.score)
407-
psi_a, psi_b = self.score(y, d, g_hat0, g_hat1, m_hat, smpls)
407+
psi_a, psi_b = self.score(y=y, d=d,
408+
g_hat0=g_hat0, g_hat1=g_hat1, m_hat=m_hat,
409+
smpls=smpls)
408410

409411
return psi_a, psi_b
410412

0 commit comments

Comments
 (0)