[Serialization] Get SubstitutionList directly from a NameAliasType.

Author: DougGregor

include/swift/AST/Types.h

@@ -1620,12 +1620,6 @@ class NameAliasType final
     return getNumSubstitutions();
   }
 
-  /// Retrieve the set of substitutions to be applied to the declaration to
-  /// produce the underlying type.
-  SubstitutionList getSubstitutionList() const {
-    return {getTrailingObjects<Substitution>(), getNumSubstitutions()};
-  }
-
   /// Retrieve the generic signature used for substitutions.
   GenericSignature *getGenericSignature() const {
     return getNumSubstitutions() > 0
@@ -1651,6 +1645,12 @@ class NameAliasType final
                                              : Type();
   }
 
+  /// Retrieve the set of substitutions to be applied to the declaration to
+  /// produce the underlying type.
+  SubstitutionList getSubstitutionList() const {
+    return {getTrailingObjects<Substitution>(), getNumSubstitutions()};
+  }
+
   /// Retrieve the substitution map applied to the declaration's underlying
   /// to produce the described type.
   SubstitutionMap getSubstitutionMap() const;

lib/Serialization/Serialization.cpp

@@ -3631,10 +3631,7 @@ void Serializer::writeType(Type ty) {
                              addTypeRef(alias->getParent()),
                              addTypeRef(alias->getSinglyDesugaredType()));
     // Write the set of substitutions.
-    SmallVector<Substitution, 4> flatSubs;
-    if (auto genericSig = typeAlias->getGenericSignature())
-      genericSig->getSubstitutions(alias->getSubstitutionMap(), flatSubs);
-    writeSubstitutions(flatSubs, DeclTypeAbbrCodes);
+    writeSubstitutions(alias->getSubstitutionList(), DeclTypeAbbrCodes);
     break;
   }