Fix typos #724
Merged
Fix typos #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwwall
reviewed
Jul 27, 2022
| @@ -21,22 +21,23 @@ Finding Something Interesting to Work on: | |||
| or "help wanted", those are good places to start for someone not yet | |||
| familiar with the ESAPI code base. | |||
|
|
|||
| You will need a account on GitHub though. Once you create one, let me know | |||
| You will need a account on GitHub though. Once you create one, let us know | |||
There was a problem hiding this comment.
Missed one. Should say 'an account'.
kwwall
reviewed
Jul 27, 2022
| @@ -47,8 +48,7 @@ Overview: | |||
|
|
|||
| Required Software: | |||
| We use Maven for building. Maven 3.3.9 or later is required. You also need | |||
| JDK 8 or later. | |||
| [Note: If you use JDK 9 or later, there will be multiple | |||
| JDK 8 or later. [Note: If you use JDK 9 or later, there will be multiple | |||
There was a problem hiding this comment.
@noloader - I think you got this to work with Java 11, right? And submitted a PR for that? If so, we should adjust this warning for JDK 9 or later.
|
@noloader - I had 2 comments that should be addressed, but we can address those later. I'm going to merge this now, but feel free to do another PR to address these 2 comments or simply include them with your any of your other PRs. |
|
And dang... I forgot to ask @noloader if he would create a short GitHub issue and reference this PR so we can include that in the release notes. Just assign it to yourself and I'll be watching for it and will mark it closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few typos. Break a few lines at column 80.