Skip to content

Commit 571e467

Browse files
committed
Merge #60: CI: pin byteorder to 1.4.3
9afa79c readme: update MSRV pinning instructions (Riccardo Casatta) 275da64 ci: remove old MSRV pinnings (Riccardo Casatta) dab0108 fuzz: pin byteorder to 1.4.3 (Riccardo Casatta) b90f8f9 CI: pin byteorder to 1.4.3 (Riccardo Casatta) Pull request description: ACKs for top commit: LeoComandini: utACK 9afa79c apoelstra: ACK 9afa79c Tree-SHA512: 3a309a9d9b069bf45d1c130c1daabf5cba127f2a4ed4b1e508d068e6f5fbdce338f2cbd79127e9b120375232a2589ffb9398307099c15b00c6f3ae474ddab4eb
2 parents 856543b + 9afa79c commit 571e467

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,12 @@ Some dependencies do not play nicely with our MSRV, if you are running the tests
4747
you may need to pin as follows:
4848

4949
```
50-
cargo update -p serde --precise 1.0.156
50+
cargo update -p byteorder --precise 1.4.3
5151
```
5252

53+
Note this list could sometimes be not exhaustive because not enforced by CI.
54+
If you have any issues check the script executed in CI: `contrib/test.sh`
55+
5356
## Contributing
5457
Contributions are generally welcome. If you intend to make larger changes please
5558
discuss them in an issue before PRing them to avoid duplicate work and

contrib/test.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,7 @@ rustc --version
99

1010
# Pin dependencies required to build with Rust 1.58
1111
if cargo --version | grep "1\.58"; then
12-
cargo update -p serde_json --precise 1.0.99
13-
cargo update -p serde --precise 1.0.156
14-
cargo update -p quote --precise 1.0.30
15-
cargo update -p proc-macro2 --precise 1.0.63
16-
cargo update -p serde_test --precise 1.0.152
12+
cargo update -p byteorder --precise 1.4.3
1713
fi
1814

1915
# Format if told to

fuzz/fuzz.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ fi
1818
cargo --version
1919
rustc --version
2020

21+
cargo update -p byteorder --precise 1.4.3
22+
2123
# Testing
2224
cargo install --force honggfuzz --no-default-features
2325
for targetFile in $targetFiles; do

0 commit comments

Comments
 (0)