Skip to content

Commit 6767077

Browse files
icywang86ruiEliza Zhang
authored andcommitted
Add integration tests to run training jobs with sagemaker (aws#81)
* Add mnist sagemaker tests * Use account-id instead of ecr-image * Merge gpu and cpu sagemaker tests * remove _run_mnist_training
1 parent 48a734e commit 6767077

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

test/conftest.py

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ def pytest_addoption(parser):
3636
parser.addoption('--framework-version', default='1.10.0')
3737
parser.addoption('--processor', default='cpu', choices=['gpu', 'cpu'])
3838
parser.addoption('--py-version', default='3', choices=['2', '3'])
39+
parser.addoption('--account-id', default='142577830533')
40+
parser.addoption('--instance-type', default=None)
3941

4042

4143
@pytest.fixture(scope='session')
@@ -80,6 +82,17 @@ def sagemaker_local_session(region):
8082
return LocalSession(boto_session=boto3.Session(region_name=region))
8183

8284

85+
@pytest.fixture(scope='session')
86+
def account_id(request):
87+
return request.config.getoption('--account-id')
88+
89+
90+
@pytest.fixture(scope='session')
91+
def instance_type(request, processor):
92+
return request.config.getoption('--instance-type') or \
93+
'ml.c4.xlarge' if processor == 'cpu' else 'ml.p2.xlarge'
94+
95+
8396
@pytest.fixture(autouse=True)
8497
def skip_by_device_type(request, processor):
8598
is_gpu = (processor == 'gpu')
@@ -91,3 +104,9 @@ def skip_by_device_type(request, processor):
91104
@pytest.fixture(scope='session')
92105
def docker_image(docker_base_name, tag):
93106
return '{}:{}'.format(docker_base_name, tag)
107+
108+
109+
@pytest.fixture(scope='session')
110+
def ecr_image(account_id, docker_base_name, tag, region):
111+
return '{}.dkr.ecr.{}.amazonaws.com/{}:{}'.format(
112+
account_id, region, docker_base_name, tag)

0 commit comments

Comments
 (0)