Skip to content

Typo, "subsciptions" -> "subscriptions" #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2019

Conversation

rharriso
Copy link
Contributor

@rharriso rharriso commented May 25, 2019

The argument name for toSchema has a typo. This will be a breaking change since you can reference arguments by name in Kotlin

@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #227 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #227   +/-   ##
=========================================
  Coverage     98.43%   98.43%           
  Complexity      178      178           
=========================================
  Files            57       57           
  Lines           575      575           
  Branches         99       99           
=========================================
  Hits            566      566           
  Misses            4        4           
  Partials          5        5
Impacted Files Coverage Δ Complexity Δ
src/main/kotlin/com/expedia/graphql/toSchema.kt 100% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c26c0...fb81cdd. Read the comment docs.

@smyrick
Copy link
Contributor

smyrick commented May 27, 2019

Whoops, good catch!

@smyrick smyrick merged commit 817f894 into ExpediaGroup:master May 27, 2019
@smyrick smyrick added the changes: major Changes require a major version label May 28, 2019
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: major Changes require a major version
Development

Successfully merging this pull request may close these issues.

2 participants