Skip to content

publish only the schema-generator module #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2019
Merged

publish only the schema-generator module #268

merged 1 commit into from
Jul 19, 2019

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Jul 18, 2019

Set the profiles for release and javadoc to only run on the schema-generator module as the example app doesn't need to be published

publish only the schema-generator module
0632463 
Set the profiles for release and javadoc to only run on the schema-generator module as the example app doesn't need to be published
@smyrick smyrick added the type: tool update CI, code coverage, or linter updates label Jul 18, 2019
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #268   +/-   ##
=========================================
  Coverage     96.81%   96.81%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           691      691           
  Branches        122      122           
=========================================
  Hits            669      669           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1e046...0632463. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #268   +/-   ##
=========================================
  Coverage     96.81%   96.81%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           691      691           
  Branches        122      122           
=========================================
  Hits            669      669           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1e046...0632463. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 19, 2019 •
edited
Loading

Codecov Report

Merging #268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #268   +/-   ##
=========================================
  Coverage     96.81%   96.81%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           691      691           
  Branches        122      122           
=========================================
  Hits            669      669           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1e046...0632463. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 19, 2019 •
edited
Loading

Codecov Report

Merging #268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #268   +/-   ##
=========================================
  Coverage     96.81%   96.81%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           691      691           
  Branches        122      122           
=========================================
  Hits            669      669           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1e046...0632463. Read the comment docs.

dariuszkuc
dariuszkuc reviewed Jul 19, 2019
View reviewed changes
pom.xml
@@ -337,6 +342,11 @@
</property>
</activation>

<!-- Exclude the example app from releases -->
<modules>
<module>graphql-kotlin-schema-generator</module>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should already be handled by -> https://github.com/ExpediaDotCom/graphql-kotlin/blob/master/graphql-kotlin-spring-example/pom.xml#L81

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, release runs nexus-staging-maven-plugin during deploy phase which was not skipped.

dariuszkuc
dariuszkuc reviewed Jul 19, 2019
View reviewed changes
pom.xml

<!-- Exclude the example app from javadoc packages -->
<modules>
<module>graphql-kotlin-schema-generator</module>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this should be the same as -> https://github.com/ExpediaDotCom/graphql-kotlin/blob/master/graphql-kotlin-spring-example/pom.xml#L89

@smyrick smyrick merged commit 53b2ca0 into ExpediaGroup:master Jul 19, 2019
@smyrick smyrick deleted the publish-generator-only branch July 19, 2019 15:49
smyrick added a commit to smyrick/graphql-kotlin that referenced this pull request Sep 11, 2019
@smyrick
publish only the schema-generator module (ExpediaGroup#268)
c62f209 
Set the profiles for release and javadoc to only run on the schema-generator module as the example app doesn't need to be published
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
@smyrick
publish only the schema-generator module (ExpediaGroup#268)
74f0afc 
Set the profiles for release and javadoc to only run on the schema-generator module as the example app doesn't need to be published
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariuszkuc dariuszkuc dariuszkuc approved these changes

Assignees
No one assigned
Labels
type: tool update CI, code coverage, or linter updates
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smyrick @dariuszkuc