Skip to content

fix: use maven release plugin in update-version.sh travis script #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2019
Merged

fix: use maven release plugin in update-version.sh travis script #273

merged 1 commit into from
Jul 19, 2019

Conversation

dariuszkuc
Copy link
Collaborator

versions-maven-plugin is unable to automatically increment snapshot versions of non-standard version project (e.g. 1.0.0-RC1-SNAPSHOT).

@dariuszkuc
fix: use maven release plugin in update-version.sh travis script
a6668a1 
versions-maven-plugin is unable to automatically increment snapshot versions of non-standard version project (e.g. 1.0.0-RC1-SNAPSHOT).
@smyrick smyrick added the type: tool update CI, code coverage, or linter updates label Jul 19, 2019
@dariuszkuc dariuszkuc merged commit 9660e59 into ExpediaGroup:master Jul 19, 2019
@dariuszkuc dariuszkuc deleted the fix_version_update branch July 19, 2019 21:46
@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           694      694           
  Branches        124      124           
=========================================
  Hits            672      672           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa35...a6668a1. Read the comment docs.

10 similar comments
@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           694      694           
  Branches        124      124           
=========================================
  Hits            672      672           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa35...a6668a1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           694      694           
  Branches        124      124           
=========================================
  Hits            672      672           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa35...a6668a1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           694      694           
  Branches        124      124           
=========================================
  Hits            672      672           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa35...a6668a1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           694      694           
  Branches        124      124           
=========================================
  Hits            672      672           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa35...a6668a1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           694      694           
  Branches        124      124           
=========================================
  Hits            672      672           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa35...a6668a1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           694      694           
  Branches        124      124           
=========================================
  Hits            672      672           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa35...a6668a1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           694      694           
  Branches        124      124           
=========================================
  Hits            672      672           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa35...a6668a1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           694      694           
  Branches        124      124           
=========================================
  Hits            672      672           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa35...a6668a1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           694      694           
  Branches        124      124           
=========================================
  Hits            672      672           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa35...a6668a1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 20, 2019 •
edited
Loading

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      196      196           
=========================================
  Files            61       61           
  Lines           694      694           
  Branches        124      124           
=========================================
  Hits            672      672           
  Misses            9        9           
  Partials         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9aa35...a6668a1. Read the comment docs.

smyrick pushed a commit to smyrick/graphql-kotlin that referenced this pull request Sep 11, 2019
@dariuszkuc
fix: use maven release plugin in update-version.sh travis script (Exp…
3734e68 
…ediaGroup#273)

versions-maven-plugin is unable to automatically increment snapshot versions of non-standard version project (e.g. 1.0.0-RC1-SNAPSHOT).
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
@dariuszkuc
fix: use maven release plugin in update-version.sh travis script (Exp…
dce671b 
…ediaGroup#273)

versions-maven-plugin is unable to automatically increment snapshot versions of non-standard version project (e.g. 1.0.0-RC1-SNAPSHOT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smyrick smyrick smyrick approved these changes

Assignees
No one assigned
Labels
type: tool update CI, code coverage, or linter updates
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dariuszkuc @smyrick