Skip to content

add more test coverage for federation #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Sep 6, 2019

Add some unit tests for non-covered files to get us higher before the 1.0.0 release

No code changes, just move and add test files

@smyrick smyrick added the type: tool update CI, code coverage, or linter updates label Sep 6, 2019
@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #327 into master will increase coverage by 2.45%.
The diff coverage is 73.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #327      +/-   ##
============================================
+ Coverage     93.66%   96.11%   +2.45%     
  Complexity      274      274              
============================================
  Files            79       80       +1     
  Lines           979      979              
  Branches        178      180       +2     
============================================
+ Hits            917      941      +24     
+ Misses           36       11      -25     
- Partials         26       27       +1
Impacted Files Coverage Δ Complexity Δ
...oup/graphql/federation/execution/EntityResolver.kt 86.95% <0%> (+4.02%) 2 <0> (-4) ⬇️
...diagroup/graphql/federation/execution/resolvers.kt 77.77% <77.77%> (ø) 0 <0> (?)
...expediagroup/graphql/federation/types/_FieldSet.kt 100% <0%> (+46.15%) 0% <0%> (ø) ⬇️
.../com/expediagroup/graphql/federation/types/_Any.kt 86.95% <0%> (+56.52%) 0% <0%> (ø) ⬇️
...ql/federation/exception/FederatedRequestFailure.kt 100% <0%> (+71.42%) 6% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3149822...fdd8350. Read the comment docs.

@smyrick smyrick added this to the 1.0.0 milestone Sep 6, 2019
@mykevinjung mykevinjung merged commit ef94e70 into ExpediaGroup:master Sep 6, 2019
@smyrick smyrick deleted the test-coverage branch September 6, 2019 22:50
smyrick added a commit to smyrick/graphql-kotlin that referenced this pull request Sep 11, 2019
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: tool update CI, code coverage, or linter updates
Development

Successfully merging this pull request may close these issues.

3 participants