spring-server: context web filter should only apply on graphql routes #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
============================================
+ Coverage 97.61% 97.62% +0.01%
- Complexity 318 323 +5
============================================
Files 104 104
Lines 1217 1223 +6
Branches 198 198
============================================
+ Hits 1188 1194 +6
Misses 9 9
Partials 20 20
Continue to review full report at Codecov.
|
tapaderster
reviewed
Sep 27, 2019
...-spring-server/src/main/kotlin/com/expediagroup/graphql/spring/execution/ContextWebFilter.kt
Outdated
Show resolved
Hide resolved
tapaderster
reviewed
Sep 27, 2019
...ng-server/src/test/kotlin/com/expediagroup/graphql/spring/context/GraphQLContextFactoryIT.kt
Outdated
Show resolved
Hide resolved
tapaderster
approved these changes
Sep 27, 2019
smyrick
approved these changes
Sep 27, 2019
smyrick
added
changes: patch
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…ExpediaGroup#386) * spring-server: context web filter should only apply on graphql routes * update to simple string compare instead of regex * update order of custom filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
ContextWebFiltershould only be applicable on/graphqland/subscriptionroutes.