Skip to content

federation: add tests to verify custom directive support #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dariuszkuc
Copy link
Collaborator

📝 Description

Add tests that verify that generated federated schema does not return custom directives in the _service { sdl } query.

🔗 Related Issues

#373
#374

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #388 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #388      +/-   ##
============================================
+ Coverage     97.61%   97.61%   +<.01%     
  Complexity      318      318              
============================================
  Files           104      104              
  Lines          1217     1218       +1     
  Branches        198      198              
============================================
+ Hits           1188     1189       +1     
  Misses            9        9              
  Partials         20       20
Impacted Files Coverage Δ Complexity Δ
...raphql/federation/FederatedSchemaGeneratorHooks.kt 100% <100%> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41524f4...ab2448b. Read the comment docs.

@tapaderster tapaderster merged commit 40649dc into ExpediaGroup:master Sep 27, 2019
@dariuszkuc dariuszkuc deleted the federation_custom_directives branch September 27, 2019 16:39
@smyrick smyrick added the type: documentation Documentation or test changes label Sep 27, 2019
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Documentation or test changes
Development

Successfully merging this pull request may close these issues.

5 participants