Remove reflections lib in favor of ClassGraph #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ExpediaGroup#449 There is a securty issue with one of the dependencies of org.reflections:reflection:0.9.11. Instead of resolving the dep issue we should migrate away from this library since the last version was released in 2017. https://github.com/classgraph/classgraph is an active supported library with reported faster implementation of reflection
smyrick
added
changes: patch
dariuszkuc
reviewed
Oct 22, 2019
...-kotlin-schema-generator/src/main/kotlin/com/expediagroup/graphql/generator/SubTypeMapper.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
============================================
+ Coverage 97.92% 97.94% +0.01%
- Complexity 326 328 +2
============================================
Files 106 106
Lines 1254 1265 +11
Branches 206 207 +1
============================================
+ Hits 1228 1239 +11
Misses 7 7
Partials 19 19
Continue to review full report at Codecov.
|
|
Not sure what is going on with GH actions builds pass locally and on travis. |
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Remove reflections lib in favor of ClassGraph Fixes ExpediaGroup#449 There is a securty issue with one of the dependencies of org.reflections:reflection:0.9.11. Instead of resolving the dep issue we should migrate away from this library since the last version was released in 2017. https://github.com/classgraph/classgraph is an active supported library with reported faster implementation of reflection * Remove val property from SubTypeMapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
There is a security issue with one of the dependencies of
org.reflections:reflection:0.9.11. Instead of resolving the dep issue we should migrate away from this library since the last version was released in 2017.https://github.com/classgraph/classgraph is an active supported library with reported faster implementation of reflection.
The security issue was in
com.google.guava:guava:20.0but since we were still using some guava code in our library I have addedcom.google.guava:guava:28-jreas an explicit dependency🔗 Related Issues
Fixes #449