chore: reduce complexity of generateScreenshotPath

Signed-off-by: Jakub Freisler <[email protected]>

Author: FRSgit

packages/cypress-plugin-visual-regression-diff/src/screenshotPath.utils.ts

@@ -15,6 +15,24 @@ const resetMap = (map: Record<string, unknown>) => {
   for (const key in map) delete map[key];
 };
 
+const parsePathPartVariables = (
+  specPath: string,
+  pathPart: string,
+  i: number
+) => {
+  if (pathPart === PATH_VARIABLES.specPath) {
+    return path.dirname(specPath);
+  } else if (i === 0 && !pathPart) {
+    // when unix-like absolute path
+    return PATH_VARIABLES.unixSystemRootPath;
+  } else if (i === 0 && WINDOWS_LIKE_DRIVE_REGEX.test(pathPart)) {
+    // when win-like absolute path
+    return path.join(PATH_VARIABLES.winSystemRootPath, pathPart[0]);
+  }
+
+  return pathPart;
+};
+
 export const generateScreenshotPath = ({
   titleFromOptions,
   imagesPath,
@@ -26,22 +44,8 @@ export const generateScreenshotPath = ({
   specPath: string;
   currentRetryNumber: number;
 }) => {
-  const parsePathPartVariables = (pathPart: string, i: number) => {
-    if (pathPart === PATH_VARIABLES.specPath) {
-      return path.dirname(specPath);
-    } else if (i === 0 && !pathPart) {
-      // when unix-like absolute path
-      return PATH_VARIABLES.unixSystemRootPath;
-    } else if (i === 0 && WINDOWS_LIKE_DRIVE_REGEX.test(pathPart)) {
-      // when win-like absolute path
-      return path.join(PATH_VARIABLES.winSystemRootPath, pathPart[0]);
-    }
-
-    return pathPart;
-  };
-
   const screenshotPath = path.join(
-    ...imagesPath.split("/").map(parsePathPartVariables),
+    ...imagesPath.split("/").map(parsePathPartVariables.bind(void 0, specPath)),
     sanitize(titleFromOptions)
   );