Skip to content

Commit 06a731d

Browse files
authored
Address feedback from the bug bash (#24)
* Addressed Angular not working, `defaultProject` is gone in new projects now * Added more error logging to the Angular codepath * `npm run dev` wasn't patching the globally installed CLI * Bumped version * Migrating to ESM * Adding nuxt & nuxt3 to Github Actions * Bumping deps * Fix dynamic import paths in Windows with pathToFileURL * Adding Windows tests to Actions * Marked as compatible with Node 16, 18. * Dropped Node 14 from Actions * Pack filesystem NPM overrides * Console log NPM install * Integrate with [firebase-js-sdk#6526](firebase/firebase-js-sdk#6526) and [firebase-tools##4868](firebase/firebase-tools#4868) * Next broke, `next export` no longer fails for fallbacks and api routes, detect these to determine if a Cloud Function should be spun up * Fixed relative directory handling * Silenced next export failures by spawning * Rearranged framework detection order so custom servers are first * Error if it could not determine the framework * Next minimal mode
1 parent 918b28a commit 06a731d

File tree

26 files changed

+4538
-6751
lines changed

26 files changed

+4538
-6751
lines changed

.github/workflows/test.yml

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,21 @@ jobs:
5151
needs: build
5252
strategy:
5353
matrix:
54-
os: [ ubuntu-latest, macos-latest ]
55-
node: [ "14", "16" ]
56-
framework: [ "next", "angular", "custom" ]
54+
os: [ ubuntu-latest, macos-latest, windows-latest ]
55+
node: [ "16", "18" ]
56+
framework: [ "next", "angular", "custom", "nuxt", "nuxt3" ]
5757
exclude:
58-
# seeing failures on this one, skip for now
59-
- os: ubuntu-latest
60-
node: 14
61-
framework: angular
58+
# Engine failures for Node 18
59+
- node: 18
60+
framework: next
61+
- node: 18
62+
framework: nuxt
63+
- node: 18
64+
framework: nuxt3
65+
# JSON serialization problem
66+
- node: 16
67+
framework: nuxt
68+
os: windows-latest
6269
fail-fast: false
6370
name: Test ${{ matrix.framework }} on Node ${{ matrix.node }} (${{ matrix.os }})
6471
steps:
@@ -91,7 +98,7 @@ jobs:
9198
- name: Test
9299
run: |
93100
npm i -g firebase-tools
94-
npm i --only production --force --ignore-scripts --save --prefix $(npm root -g)/firebase-tools $(npm pack .)
101+
node --loader ts-node/esm ./tools/dev.ts
95102
firebase --open-sesame frameworkawareness
96103
npm run test:${{ matrix.framework }}
97104
env:
@@ -103,7 +110,7 @@ jobs:
103110
strategy:
104111
matrix:
105112
os: [ ubuntu-latest, macos-latest ]
106-
node: [ "14", "16" ]
113+
node: [ "16" ] # lots of engine failures with Node 18, skip for now
107114
exclude:
108115
# we build with this combination, safely skip
109116
- os: ubuntu-latest
@@ -130,11 +137,7 @@ jobs:
130137
- name: Build
131138
run: npm run build
132139
- name: Test
133-
run: |
134-
npm i -g firebase-tools
135-
npm i --only production --force --ignore-scripts --save --prefix $(npm root -g)/firebase-tools $(npm pack .)
136-
firebase --open-sesame frameworkawareness
137-
npm run test
140+
run: npm run test
138141
env:
139142
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
140143

0 commit comments

Comments
 (0)