Ensure the DDL trigger requests are cached (#7426)

While this commit does not fix all problems with cached triggers, I see no good reason to defer it.

Author: dyemanov

src/jrd/exe.cpp

@@ -560,35 +560,49 @@ void EXE_execute_ddl_triggers(thread_db* tdbb, jrd_tra* transaction, bool preTri
 	{
 		TrigVector triggers;
 		TrigVector* triggersPtr = &triggers;
+		HalfStaticArray<Trigger*, 4> cachedTriggers;
 
-		for (const auto& trigger : *attachment->att_ddl_triggers)
+		for (auto& trigger : *attachment->att_ddl_triggers)
 		{
 			const auto type = trigger.type & ~TRIGGER_TYPE_MASK;
 			const bool preTrigger = ((type & 1) == 0);
 
 			if ((type & (1LL << action)) && (preTriggers == preTrigger))
 			{
 				triggers.add() = trigger;
+				cachedTriggers.add(&trigger);
 			}
 		}
 
 		if (triggers.hasData())
 		{
+			FbLocalStatus tempStatus;
+
 			jrd_tra* const oldTransaction = tdbb->getTransaction();
 			tdbb->setTransaction(transaction);
 
 			try
 			{
 				EXE_execute_triggers(tdbb, &triggersPtr, NULL, NULL, TRIGGER_DDL,
 					preTriggers ? StmtNode::PRE_TRIG : StmtNode::POST_TRIG);
-
-				tdbb->setTransaction(oldTransaction);
 			}
-			catch (const Exception&)
+			catch (const Exception& ex)
 			{
-				tdbb->setTransaction(oldTransaction);
-				throw;
+				ex.stuffException(&tempStatus);
 			}
+
+			tdbb->setTransaction(oldTransaction);
+
+			// Triggers could be compiled inside EXE_execute_triggers(),
+			// so ensure the new pointers are copied back to the cache
+			fb_assert(triggers.getCount() == cachedTriggers.getCount());
+			for (unsigned i = 0; i < triggers.getCount(); i++)
+			{
+				*cachedTriggers[i] = triggers[i];
+				triggers[i].extTrigger = nullptr; // avoid deletion inside d'tor
+			}
+
+			tempStatus.check();
 		}
 	}
 }