Fix #7472 - Window functions may lead to crash interacting with others exceptions.

Author: asfernandes

src/jrd/recsrc/RecordSource.h

@@ -765,6 +765,15 @@ namespace Jrd
 			return savedPosition;
 		}
 
+		void restore()
+		{
+			if (!moved)
+				return;
+
+			// Position the stream where we received it.
+			moveWithinPartition(0);
+		}
+
 		bool moveWithinPartition(SINT64 delta);
 		bool moveWithinFrame(SINT64 delta);
 
@@ -776,7 +785,7 @@ namespace Jrd
 		FB_UINT64 frameStart;
 		FB_UINT64 frameEnd;
 		FB_UINT64 savedPosition;
-		bool moved;
+		bool moved = false;
 	};
 
 	template <typename ThisType, typename NextType>

src/jrd/recsrc/WindowedStream.cpp

@@ -28,8 +28,8 @@
 #include "../jrd/par_proto.h"
 #include "../jrd/vio_proto.h"
 #include "../jrd/optimizer/Optimizer.h"
-
 #include "RecordSource.h"
+#include <exception>
 
 using namespace Firebird;
 using namespace Jrd;
@@ -862,7 +862,7 @@ bool WindowedStream::WindowStream::internalGetRecord(thread_db* tdbb) const
 				record->clearNull(id);
 			}
 
-			window.moveWithinPartition(0);
+			window.restore();
 		}
 	}
 
@@ -1078,19 +1078,20 @@ SlidingWindow::SlidingWindow(thread_db* aTdbb, const BaseBufferedStream* aStream
 	  partitionStart(aPartitionStart),
 	  partitionEnd(aPartitionEnd),
 	  frameStart(aFrameStart),
-	  frameEnd(aFrameEnd),
-	  moved(false)
+	  frameEnd(aFrameEnd)
 {
 	savedPosition = stream->getPosition(request) - 1;
 }
 
 SlidingWindow::~SlidingWindow()
 {
-	if (!moved)
-		return;
-
-	// Position the stream where we received it.
-	moveWithinPartition(0);
+#ifdef DEV_BUILD
+#if __cpp_lib_uncaught_exceptions >= 201411L
+	fb_assert(!moved || std::uncaught_exceptions());
+#else
+	fb_assert(!moved || std::uncaught_exception());
+#endif
+#endif
 }
 
 // Move in the window without pass partition boundaries.
@@ -1101,7 +1102,7 @@ bool SlidingWindow::moveWithinPartition(SINT64 delta)
 	if (newPosition < partitionStart || newPosition > partitionEnd)
 		return false;
 
-	moved = true;
+	moved = delta != 0;
 
 	stream->locate(tdbb, newPosition);