Fix for #38

Author: pcisar

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 
 - #34 - Pre-1970 dates causes OverflowError
+- #38 - 'datetime.date' object has no attribute 'date'
 
 ## [1.10.1] - 2023-12-21
 

src/firebird/driver/core.py

@@ -176,7 +176,7 @@ def _encode_timestamp(v: Union[datetime.datetime, datetime.date]) -> bytes:
     if isinstance(v, datetime.datetime):
         return _util.encode_date(v.date()).to_bytes(4, 'little') + _util.encode_time(v.time()).to_bytes(4, 'little')
     if isinstance(v, datetime.date):
-        return _util.encode_date(v.date()).to_bytes(4, 'little') + _util.encode_time(datetime.time()).to_bytes(4, 'little')
+        return _util.encode_date(v).to_bytes(4, 'little') + _util.encode_time(datetime.time()).to_bytes(4, 'little')
     raise ValueError("datetime.datetime or datetime.date expected")
 
 def _is_fixed_point(dialect: int, datatype: SQLDataType, subtype: int,

tests/test_driver.py

@@ -1485,6 +1485,16 @@ def test_insert_datetime(self):
             self.assertListEqual(rows,
                                  [(5, datetime.date(1859, 11, 16), datetime.time(15, 0, 1, 200000),
                                    datetime.datetime(1859, 11, 16, 15, 0, 1, 200000))])
+            # Pass date instead datetime for timestamp field (fix for #38)
+            now = datetime.datetime(2011, 11, 13, 15, 00, 1, 200000)
+            cur.execute('insert into T2 (C1,C6,C7,C8) values (?,?,?,?)', [6, now.date(), now.time(), now.date()])
+            self.con.commit()
+            cur.execute('select C1,C6,C7,C8 from T2 where C1 = 6')
+            rows = cur.fetchall()
+            self.assertListEqual(rows,
+                                 [(6, datetime.date(2011, 11, 13), datetime.time(15, 0, 1, 200000),
+                                   datetime.datetime(2011, 11, 13, 0, 0, 0, 0))])
+
     def test_insert_blob(self):
         with self.con.cursor() as cur, self.con2.cursor() as cur2:
             cur.execute('insert into T2 (C1,C9) values (?,?)', [4, 'This is a BLOB!'])