Skip to content

Commit 9f1a315

Browse files
committed
Fix issue with Firebird 4 string dbinfo items
1 parent 7f1cb3e commit 9f1a315

File tree

5 files changed

+18
-13
lines changed

5 files changed

+18
-13
lines changed

docs/changelog.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
Changelog
33
#########
44

5+
Version 1.3.1
6+
=============
7+
8+
* Fix unregistered bug: wrong handling of Firebird 4 string info parameters.
9+
510
Version 1.3.0
611
=============
712

docs/conf.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323
author = 'Pavel Císař'
2424

2525
# The short X.Y version
26-
version = '1.3.0'
26+
version = '1.3.1'
2727

2828
# The full version, including alpha/beta/rc tags
29-
release = '1.3.0'
29+
release = '1.3.1'
3030

3131

3232
# -- General configuration ---------------------------------------------------

firebird/driver/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,4 @@
5959
Server, Statement
6060

6161
#: Current driver version, SEMVER string.
62-
__VERSION__ = '1.3.0'
62+
__VERSION__ = '1.3.1'

firebird/driver/core.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1060,9 +1060,9 @@ def __init__(self, connection: Connection):
10601060
DbInfoCode.DB_ID: self.__db_id,
10611061
DbInfoCode.IMPLEMENTATION: self.__implementation,
10621062
DbInfoCode.IMPLEMENTATION_OLD: self.__implementation_old,
1063-
DbInfoCode.VERSION: self.__info_string,
1064-
DbInfoCode.FIREBIRD_VERSION: self.__info_string,
1065-
DbInfoCode.CRYPT_KEY: self.__info_string,
1063+
DbInfoCode.VERSION: self._info_string,
1064+
DbInfoCode.FIREBIRD_VERSION: self._info_string,
1065+
DbInfoCode.CRYPT_KEY: self._info_string,
10661066
DbInfoCode.USER_NAMES: self.__user_names,
10671067
DbInfoCode.ACTIVE_TRANSACTIONS: self.__tra_active,
10681068
DbInfoCode.LIMBO: self.__tra_limbo,
@@ -1102,7 +1102,7 @@ def __init__(self, connection: Connection):
11021102
DbInfoCode.DB_PROVIDER: self.response.read_sized_int,
11031103
DbInfoCode.PAGES_USED: self.response.read_sized_int,
11041104
DbInfoCode.PAGES_FREE: self.response.read_sized_int,
1105-
DbInfoCode.CRYPT_KEY: self.__info_string,
1105+
DbInfoCode.CRYPT_KEY: self._info_string,
11061106
DbInfoCode.CRYPT_STATE: self.__crypt_state,
11071107
DbInfoCode.CONN_FLAGS: self.__con_state,
11081108
DbInfoCode.BACKOUT_COUNT: self.__tbl_perf_count,
@@ -1142,7 +1142,7 @@ def __implementation_old(self) -> Tuple[int, int]:
11421142
impl_number = self.response.read_byte()
11431143
class_number = self.response.read_byte()
11441144
return (impl_number, class_number)
1145-
def __info_string(self) -> str:
1145+
def _info_string(self) -> str:
11461146
self.response.read_byte() # Cluster length
11471147
self.response.read_short() # number of strings
11481148
return self.response.read_pascal_string()
@@ -1507,14 +1507,14 @@ def __init__(self, connection: Connection):
15071507
DbInfoCode.STMT_TIMEOUT_DB: self.response.read_sized_int,
15081508
DbInfoCode.STMT_TIMEOUT_ATT: self.response.read_sized_int,
15091509
DbInfoCode.PROTOCOL_VERSION: self.response.read_sized_int,
1510-
DbInfoCode.CRYPT_PLUGIN: self.__info_string,
1510+
DbInfoCode.CRYPT_PLUGIN: self._info_string,
15111511
DbInfoCode.CREATION_TIMESTAMP_TZ: self.__creation_tstz,
1512-
DbInfoCode.WIRE_CRYPT: self.__info_string,
1512+
DbInfoCode.WIRE_CRYPT: self._info_string,
15131513
DbInfoCode.FEATURES: self.__features,
15141514
DbInfoCode.NEXT_ATTACHMENT: self.response.read_sized_int,
15151515
DbInfoCode.NEXT_STATEMENT: self.response.read_sized_int,
1516-
DbInfoCode.DB_GUID: self.__info_string,
1517-
DbInfoCode.DB_FILE_ID: self.__info_string,
1516+
DbInfoCode.DB_GUID: self._info_string,
1517+
DbInfoCode.DB_FILE_ID: self._info_string,
15181518
DbInfoCode.REPLICA_MODE: self.__replica_mode,
15191519
})
15201520
def __creation_tstz(self) -> datetime.datetime:

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ all-files=True
55

66
[metadata]
77
name = firebird-driver
8-
version = 1.3.0
8+
version = 1.3.1
99
description = Firebird driver
1010
long_description = file: README.rst
1111
long_description_content_type = text/x-rst; charset=UTF-8

0 commit comments

Comments
 (0)