Skip to content

Commit 0f3b819

Browse files
authored
Merge pull request #543 from FriendsOfSymfony/fix-php-http-dependency
php-http/message stopped providing php-http/message-factory
2 parents 652f4f5 + 1fe8f1c commit 0f3b819

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363

6464
legacyPHP:
6565
name: PHP 7.2 Varnish 6
66-
runs-on: ubuntu-18.04
66+
runs-on: ubuntu-20.04
6767
env:
6868
VARNISH_VERSION: '6.6'
6969
VARNISH_MODULES_VERSION: '0.18.0'
@@ -169,7 +169,7 @@ jobs:
169169

170170
lowest:
171171
name: PHP ${{ matrix.php }} Lowest, Varnish 3
172-
runs-on: ubuntu-18.04
172+
runs-on: ubuntu-20.04
173173
env:
174174
VARNISH_VERSION: '3.0'
175175
VARNISH_MODULES_VERSION: ''

composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
"php-http/client-implementation": "^1.0 || ^2.0",
2828
"php-http/client-common": "^1.1.0 || ^2.0",
2929
"php-http/message": "^1.0 || ^2.0",
30+
"php-http/message-factory": "^1.0",
3031
"php-http/discovery": "^1.12"
3132
},
3233
"require-dev": {

tests/Functional/Varnish/UserContextFailureTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ class UserContextFailureTest extends VarnishTestCase
3131
public function setUp(): void
3232
{
3333
// needs to be decided before doing the setup
34-
$this->mode = 'testHashRequestFailure' === $this->getName() ? 'failure' : 'cache';
34+
// phpunit 9 calls the method getName(), phpunit 10 name()
35+
$name = method_exists($this, 'name') ? $this->name() : $this->getName(); /* @phpstan-ignore-line */
36+
$this->mode = 'testHashRequestFailure' === $name ? 'failure' : 'cache';
3537

3638
parent::setUp();
3739
}

0 commit comments

Comments
 (0)