Merge pull request #441 from FriendsOfSymfony/dead-code

some code inspection cleanups

Author: dbu

src/CacheInvalidator.php

@@ -115,8 +115,6 @@ public function supports($operation)
      *
      * @param EventDispatcherInterface $eventDispatcher
      *
-     * @return $this
-     *
      * @throws \Exception when trying to override the event dispatcher
      */
     public function setEventDispatcher(EventDispatcherInterface $eventDispatcher)

src/Exception/InvalidUrlException.php

@@ -14,7 +14,7 @@
 /**
  * Thrown during setup if the configuration for a proxy client is invalid.
  */
-class InvalidUrlException extends InvalidArgumentException implements HttpCacheException
+class InvalidUrlException extends InvalidArgumentException
 {
     /**
      * @param string $url    the invalid URL

src/Exception/ProxyResponseException.php

@@ -12,16 +12,13 @@
 namespace FOS\HttpCache\Exception;
 
 use Http\Client\Exception\HttpException;
-use Psr\Http\Message\ResponseInterface;
 
 /**
  * Wrapping an error response from the caching proxy.
  */
 class ProxyResponseException extends \RuntimeException implements HttpCacheException
 {
     /**
-     * @param ResponseInterface $response HTTP response
-     *
      * @return ProxyResponseException
      */
     public static function proxyResponse(HttpException $exception)

src/ProxyClient/MultiplexerClient.php

@@ -13,7 +13,6 @@
 
 use FOS\HttpCache\Exception\ExceptionCollection;
 use FOS\HttpCache\Exception\InvalidArgumentException;
-use FOS\HttpCache\Exception\UnsupportedProxyOperationException;
 use FOS\HttpCache\ProxyClient\Invalidation\BanCapable;
 use FOS\HttpCache\ProxyClient\Invalidation\PurgeCapable;
 use FOS\HttpCache\ProxyClient\Invalidation\RefreshCapable;
@@ -159,27 +158,6 @@ private function invoke($interface, $method, array $arguments)
         }
     }
 
-    /**
-     * Invoke the given $method on the first available ProxyClient implementing
-     * the given $interface.
-     *
-     * @param string $interface The FQN of the interface
-     * @param string $method    The method to invoke
-     * @param array  $arguments The arguments to be passed to the method
-     *
-     * @return mixed Return value of ProxyClient method call
-     *
-     * @throws UnsupportedProxyOperationException
-     */
-    private function invokeFirst($interface, $method, array $arguments)
-    {
-        foreach ($this->getProxyClients($interface) as $proxyClient) {
-            return call_user_func_array([$proxyClient, $method], $arguments);
-        }
-
-        throw UnsupportedProxyOperationException::cacheDoesNotImplement($interface);
-    }
-
     /**
      * Get proxy clients that implement a feature interface.
      *

src/SymfonyCache/CacheEvent.php

@@ -14,7 +14,6 @@
 use Symfony\Component\EventDispatcher\Event;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpKernel\HttpCache\HttpCache;
 
 /**
  * Event raised by the HttpCache kernel.

src/SymfonyCache/DebugListener.php

@@ -12,7 +12,6 @@
 namespace FOS\HttpCache\SymfonyCache;
 
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
-use Symfony\Component\HttpFoundation\Response;
 
 /**
  * Debug handler for the symfony built-in HttpCache.

src/Test/Proxy/SymfonyProxy.php

@@ -63,7 +63,7 @@ public function clear()
         }
 
         $path = $this->getCacheDir();
-        if ('WIN' === strtoupper(substr(PHP_OS, 0, 3))) {
+        if (0 === stripos(PHP_OS, 'WIN')) {
             // @codeCoverageIgnoreStart
             system('DEL /S '.$path);
         } else {

src/Test/WebServerListenerTrait.php

@@ -35,7 +35,7 @@ public function startTestSuite($suite)
             return;
         }
 
-        if (!in_array('webserver', $suite->getGroups()) || null !== $this->pid) {
+        if (null !== $this->pid || !in_array('webserver', $suite->getGroups())) {
             return;
         }