addTags on TagHandler

Author: dbu

src/CacheInvalidator.php

@@ -160,7 +160,7 @@ public function addSubscriber(EventSubscriberInterface $subscriber)
      */
     public function setTagsHeader($tagsHeader)
     {
-        if ($this->tagHandler && $this->tagsHeader !== $tagsHeader) {
+        if ($this->tagHandler && $this->tagHandler->getTagsHeader() !== $tagsHeader) {
             $this->tagHandler = new TagHandler($this, $tagsHeader);
         }
 
@@ -176,7 +176,7 @@ public function setTagsHeader($tagsHeader)
      */
     public function getTagsHeader()
     {
-        return $this->tagsHeader;
+        return $this->tagHandler ? $this->tagHandler->getTagsHeader() : $this->tagsHeader;
     }
 
     /**

src/Handler/TagHandler.php

@@ -32,6 +32,11 @@ class TagHandler
      */
     private $tagsHeader;
 
+    /**
+     * @var array
+     */
+    private $tags = array();
+
     /**
      * Constructor
      *
@@ -49,6 +54,29 @@ public function __construct(CacheInvalidator $invalidator, $tagsHeader = 'X-Cach
         $this->tagsHeader = $tagsHeader;
     }
 
+    /**
+     * Add tags to be sent.
+     *
+     * This must be called before any response is sent to the client.
+     *
+     * @param array $tags List of tags to add.
+     */
+    public function addTags(array $tags)
+    {
+        $this->tags = array_merge($this->tags, $tags);
+    }
+
+    /**
+     * Set tags on the response.
+     *
+     * This must be called before any response is sent to the client.
+     * Make sure this is called after all addTags calls and only once.
+     */
+    public function flushTags()
+    {
+        header(sprintf('%s: %s', $this->getTagsHeader(), $this->formatTagsString($this->tags)));
+    }
+
     /**
      * Invalidate cache entries that contain any of the specified tags in their
      * tag header.
@@ -59,10 +87,48 @@ public function __construct(CacheInvalidator $invalidator, $tagsHeader = 'X-Cach
      */
     public function invalidateTags(array $tags)
     {
-        $tagExpression = sprintf('(%s)(,.+)?$', implode('|', array_map('preg_quote', $tags)));
+        $tagExpression = sprintf('(%s)(,.+)?$', implode('|', array_map('preg_quote', $this->escapeTags($tags))));
         $headers = array($this->tagsHeader => $tagExpression);
         $this->invalidator->invalidate($headers);
 
         return $this;
     }
+
+    /**
+     * Get the HTTP header name that will hold cache tags
+     *
+     * @return string
+     */
+    public function getTagsHeader()
+    {
+        return $this->tagsHeader;
+    }
+
+    /**
+     * Format the tags string.
+     *
+     * @param array $tags Non-empty list of tags to output
+     *
+     * @return string
+     */
+    protected function formatTagsString(array $tags)
+    {
+        return implode(',', $this->escapeTags(array_unique($tags)));
+    }
+
+    /**
+     * Make sure that the tags are valid.
+     *
+     * @param array $tags The tags to escape.
+     *
+     * @return array Sane tags.
+     */
+    protected function escapeTags(array $tags)
+    {
+        array_walk($tags, function (&$tag) {
+            $tag = str_replace(array(',', "\n"), array('_', '_'), $tag);
+        });
+
+        return $tags;
+    }
 }

tests/Unit/Handler/TagHandlerTest.php

@@ -48,6 +48,22 @@ public function testInvalidateTagsCustomHeader()
         $tagHandler->invalidateTags(array('post-1'));
     }
 
+    public function testEscapingTags()
+    {
+        $cacheInvalidator = \Mockery::mock('FOS\HttpCache\CacheInvalidator')
+            ->shouldReceive('invalidate')
+            ->with(array('X-Cache-Tags' => '(post_test)(,.+)?$'))
+            ->once()
+            ->shouldReceive('supports')
+            ->with(CacheInvalidator::INVALIDATE)
+            ->once()
+            ->andReturn(true)
+            ->getMock();
+
+        $tagHandler = new TagHandler($cacheInvalidator);
+        $tagHandler->invalidateTags(array('post,test'));
+    }
+
     /**
      * @expectedException \FOS\HttpCache\Exception\UnsupportedProxyOperationException
      */
@@ -62,4 +78,22 @@ public function testInvalidateUnsupported()
 
         new TagHandler($cacheInvalidator);
     }
+
+    /**
+     * @runInSeparateProcess
+     */
+    public function testTagResponse()
+    {
+        $cacheInvalidator = \Mockery::mock('FOS\HttpCache\CacheInvalidator')
+            ->shouldReceive('supports')
+            ->with(CacheInvalidator::INVALIDATE)
+            ->once()
+            ->andReturn(true)
+            ->getMock();
+
+        $tagHandler = new TagHandler($cacheInvalidator);
+        $tagHandler->addTags(array('post-1', 'test,post'));
+        $tagHandler->flushTags();
+        // it seems on cli we can not investigate the headers_list
+    }
 }