Remove empty(tags) check in ResponseTagger->getTagsHeaderValue()

andrerom · andrerom · commit b046f6140e32 · 2015-11-18T11:59:52.000+01:00
diff --git a/src/ResponseTagger.php b/src/ResponseTagger.php
@@ -61,10 +61,6 @@ public function getTagsHeaderName()
      */
     public function getTagsHeaderValue()
     {
-        if (empty($this->tags)) {
-            return '';
-        }
-
         return $this->client->getTagsHeaderValue($this->tags);
     }
 
diff --git a/tests/Unit/ResponseTaggerTest.php b/tests/Unit/ResponseTaggerTest.php
@@ -13,7 +13,7 @@
 
 use FOS\HttpCache\ResponseTagger;
 
-class TagHandlerTest extends \PHPUnit_Framework_TestCase
+class ResponseTaggerTest extends \PHPUnit_Framework_TestCase
 {
     public function testTagResponse()
     {

Original file line number	Diff line number	Diff line change
`@@ -61,10 +61,6 @@ public function getTagsHeaderName()`
`61`	`61`	`*/`
`62`	`62`	`public function getTagsHeaderValue()`
`63`	`63`	`{`
`64`		`- if (empty($this->tags)) {`
`65`		`- return '';`
`66`		`- }`
`67`		`-`
`68`	`64`	`return $this->client->getTagsHeaderValue($this->tags);`
`69`	`65`	`}`
`70`	`66`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`
`14`	`14`	`use FOS\HttpCache\ResponseTagger;`
`15`	`15`
`16`		`-class TagHandlerTest extends \PHPUnit_Framework_TestCase`
	`16`	`+class ResponseTaggerTest extends \PHPUnit_Framework_TestCase`
`17`	`17`	`{`
`18`	`18`	`public function testTagResponse()`
`19`	`19`	`{`