Add response code to cache hit/miss assertion message

Author: ddeboer

src/Test/PHPUnit/AbstractCacheConstraint.php

@@ -62,6 +62,10 @@ protected function matches($other)
      */
     protected function failureDescription($other)
     {
-        return 'the responses are identical';
+        return sprintf(
+            'response (with status code %s) %s',
+            $other->getStatusCode(),
+            $this->toString()
+        );
     }
 }

tests/Unit/Test/PHPUnit/AbstractCacheConstraintTest.php

@@ -7,9 +7,9 @@ abstract class AbstractCacheConstraintTest extends \PHPUnit_Framework_TestCase
     protected function getResponseMock()
     {
         $mock = \Mockery::mock(
-            '\Psr\Http\Message\ResponseInterface[hasHeader,getHeaderLine]'
+            '\Psr\Http\Message\ResponseInterface[hasHeader,getHeaderLine,getStatusCode]'
         );
-        
+
         return $mock;
     }
 }

tests/Unit/Test/PHPUnit/IsCacheHitConstraintTest.php

@@ -27,12 +27,14 @@ public function setUp()
 
     /**
      * @expectedException \PHPUnit_Framework_ExpectationFailedException
+     * @expectedExceptionMessage Failed asserting that response (with status code 500) is a cache hit
      */
     public function testMatches()
     {
         $response = $this->getResponseMock()
             ->shouldReceive('hasHeader')->with('cache-header')->andReturn(true)
             ->shouldReceive('getHeaderLine')->with('cache-header')->once()->andReturn('MISS')
+            ->shouldReceive('getStatusCode')->andReturn(500)
             ->getMock();
 
         $this->constraint->evaluate($response);

tests/Unit/Test/PHPUnit/IsCacheMissConstraintTest.php

@@ -27,13 +27,14 @@ public function setUp()
 
     /**
      * @expectedException \PHPUnit_Framework_ExpectationFailedException
+     * @expectedExceptionMessage Failed asserting that response (with status code 200) is a cache miss
      */
     public function testMatches()
     {
         $response = $this->getResponseMock()
             ->shouldReceive('hasHeader')->with('cache-header')->andReturn(true)
-            ->shouldReceive('getHeaderLine')->with('cache-header')->once()
-            ->andReturn('HIT')
+            ->shouldReceive('getHeaderLine')->with('cache-header')->once()->andReturn('HIT')
+            ->shouldReceive('getStatusCode')->andReturn(200)
             ->getMock();
 
         $this->constraint->evaluate($response);