allow httplug 2.0 #442
Merged
allow httplug 2.0 #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Feb 5, 2019
|
@dbu anything we can help with to get this merged? |
|
ah, it was a travis-ci hickup that made me think it does not work - a restart helped. will merge it now. |
|
as for the release with this: i'd love to wrap up #444 where we seem quite close to finished but have problems with functional tests. and i seem to not find the time to work on this :-( |
|
:( |
|
hi @elshobokshy did you want to help out with something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets wait with merging until php-http/client-common has a 2.0 release and we see php-http/guzzle6-adapter 2.0 being installed in the travis build.