Allowed server URI parts are extended: added user and pass #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerheyDolgushev
force-pushed
the
extend_server_uri_parts
branch
from
3dedd3a to
341212a
Compare
|
Failing checks do not seem to be related to the current PR. |
dbu
approved these changes
May 7, 2020
There was a problem hiding this comment.
our idea was that you would configure the http client that is injected to the dispatcher to add basic auth if this is what you want. but i see no reason why the http://user:[email protected]/ should not be supported as well.
the cs failure indeed is due to additional rules in styleci, fixing that it in #481. the travis error is because installing the documentation build system fails, i tried to fix that in #450 but never figured out whats wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow providing HTTP access credentials for the servers.