Use userInfo from server configuration when duplicating request #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! Can you add some tests so we can see what's actually going wrong now? |
|
It is related to #480 |
|
makes sense with #480. but indeed, a test for the whole scenario would be very welcome. can you do one please? |
|
@dbu Thanks a lot for a quick merge! :) |
|
yes, I'll work on tests later and open a separate PR, thanks! |
We will create an internal ticket to implement a test for this change, so we will not forget about it. And we will submit a separate PR for the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, information about "userInfo" not copied, and we see 401 response returned from cache proxy.