Skip to content

Commit a64a709

Browse files
committed
Add SessionListener::onFinishRequest method to be inline with Symfony 3.4.12
1 parent 860edff commit a64a709

File tree

2 files changed

+30
-0
lines changed

2 files changed

+30
-0
lines changed

EventListener/SessionListener.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
1515
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
16+
use Symfony\Component\HttpKernel\Event\FinishRequestEvent;
1617
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
1718
use Symfony\Component\HttpKernel\EventListener\SessionListener as BaseSessionListener;
1819

@@ -78,6 +79,13 @@ public function onKernelResponse(FilterResponseEvent $event)
7879
// noop, see class description
7980
}
8081

82+
public function onFinishRequest(FinishRequestEvent $event)
83+
{
84+
if (method_exists($this->innerListener, 'onFinishRequest')) {
85+
$this->innerListener->onFinishRequest($event);
86+
}
87+
}
88+
8189
public static function getSubscribedEvents()
8290
{
8391
return BaseSessionListener::getSubscribedEvents();

Tests/Unit/EventListener/SessionListenerTest.php

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,28 @@ public function testOnKernelRequestRemainsUntouched()
4747
$listener->onKernelRequest($event);
4848
}
4949

50+
public function testOnFinishRequestRemainsUntouched()
51+
{
52+
$event = $this
53+
->getMockBuilder('Symfony\Component\HttpKernel\Event\FinishRequestEvent')
54+
->disableOriginalConstructor()
55+
->getMock();
56+
57+
$inner = $this
58+
->getMockBuilder('Symfony\Component\HttpKernel\EventListener\SessionListener')
59+
->disableOriginalConstructor()
60+
->getMock();
61+
62+
$inner
63+
->expects($this->once())
64+
->method('onFinishRequest')
65+
->with($event)
66+
;
67+
68+
$listener = $this->getListener($inner);
69+
$listener->onFinishRequest($event);
70+
}
71+
5072
/**
5173
* @dataProvider onKernelResponseProvider
5274
*/

0 commit comments

Comments
 (0)