Allow override of request cache headers #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| headers: | ||
| overwrite: false |
There was a problem hiding this comment.
@ddeboer i am not really happy that this configuration is at the same place as the headers configuration. but i don't see where else we can put it without changing a lot in the data structure.
There was a problem hiding this comment.
It”s okay with me.
If we could change the data structure, what would you propose?
There was a problem hiding this comment.
if i knew, i would already have proposed something :-)
lets leave it at this. i will wait with merging until #128 is through,
then tag and create the 1.0 branch so we can start with this as 1.1 version
|
👍 |
dbu
added a commit
that referenced
this pull request
Oct 21, 2014
Allow override of request cache headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanedup version of #150
/cc @gonzalovilaseca