Merge bundles #16
Merged
Merge bundles #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - SYMFONY_VERSION=2.1.* | ||
| - SYMFONY_VERSION=2.2.* | ||
| - SYMFONY_VERSION=2.3.* | ||
| - SYMFONY_VERSION=dev-master |
There was a problem hiding this comment.
symfony 2.4 is out, so that should be in this list too.
do we still care about symfony < 2.3? i would suggest to ditch those, they are EOL and people still on symfony 2.1/2.2 can use the old LiipCacheControlBundle which will remain available for legacy.
|
great, looks good. i found some details and commented to prove that i went through the diff :-) once this is merged, we should try to activate travis and see what the tests are saying. |
Merge composer.json Merge configuration Merge PHPUnit config Create separate installation doc Change namespace to FOS Support Symfony 2.4 and drop 2.1/2.2 support Remove cURL check Fix search/replace mistake Fix typo Make contributors homepage URL forwards-compatible
|
Squashed commits. Feel free to have a last look and merge if you're okay with it. |
|
great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And close #3.