Fix Travis buid #191
Merged
Fix Travis buid #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
agreed. thanks! |
| @@ -26,6 +26,7 @@ | |||
| "symfony/framework-bundle": "~2.3" | |||
| }, | |||
| "require-dev": { | |||
| "friendsofsymfony/http-cache": "~1.2@dev", | |||
There was a problem hiding this comment.
don't put the same requirement in both require and require-dev (Composer warns about it). Put the dev flag directly in require (it will only affect the requirement when being in the root package anyway)
There was a problem hiding this comment.
Hm yes, but we don't want people to get the unstable version of the library when installing a tagged version of the bundle. Do we then need to keep the minimum-stability?
There was a problem hiding this comment.
@dev in requirements is root-only. It is ignored in dependencies. Only the root package can control stability restrictions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we only needed
minimum-stability: devfor testing against the dev version of the http-cache library. Unfortunately, all other vendors then got included in their dev versions too. It may be better to work with stable vendor versions (except http-cache) so our tests will suffer less from volatile vendors such as Symfony adding deprecation warnings, for instance. (We catch those warnings for our tests that run against dev version of Symfony thanks to #180.)