make tag annotations optional inside tags to allow using them without FrameworkExtraBundle #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i don't know how contao exactly works, but be aware that if users write their own controllers, they might rely on tag annotations and need to be aware of the change so that they overwrite the configuration and add the framework extra bundle themselves. |
dbu
force-pushed
the
framework-extra-bundle-dep
branch
from
9304418 to
ca1ed9b
Compare
|
@Toflar may i ask you to review this one and check if it works as intended in contao? |
|
That looks good, yes! Just the |
… Sensio FrameworkExtraBundle
dbu
force-pushed
the
framework-extra-bundle-dep
branch
from
ca1ed9b to
9bbf553
Compare
|
right, added the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #489