Skip to content

Fix several deprecation notices #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Fix several deprecation notices #581

merged 1 commit into from
Aug 6, 2022

Conversation

XWB
Copy link
Member

@XWB XWB commented Aug 4, 2022

This fixes several deprecation notices:

Method "Twig\Extension\ExtensionInterface::getFunctions()" might add "array" as a native return type declaration in the future. Do the same in implementation "FOS\HttpCacheBundle\Twig\CacheTagExtension" now to avoid errors or add an explicit @return annotation to suppress this message.

Method "Symfony\Component\EventDispatcher\EventSubscriberInterface::getSubscribedEvents()" might add "array" as a native return type declaration in the future. Do the same in implementation "FOS\HttpCacheBundle\EventListener\CacheControlListener" now to avoid errors or add an explicit @return annotation to suppress this message.

Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "FOS\HttpCacheBundle\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.

Method "Symfony\Component\DependencyInjection\Extension\ConfigurationExtensionInterface::getConfiguration()" might add "?ConfigurationInterface" as a native return type declaration in the future. Do the same in implementation "FOS\HttpCacheBundle\DependencyInjection\FOSHttpCacheExtension" now to avoid errors or add an explicit @return annotation to suppress this message. 

User Deprecated: Method "Sensio\Bundle\FrameworkExtraBundle\Configuration\ConfigurationInterface::getAliasName()" might add "string" as a native return type declaration in the future. Do the same in implementation "FOS\HttpCacheBundle\Configuration\Tag" now to avoid errors or add an explicit @return annotation to suppress this message. 

User Deprecated: Method "Sensio\Bundle\FrameworkExtraBundle\Configuration\ConfigurationInterface::allowArray()" might add "bool" as a native return type declaration in the future. Do the same in implementation "FOS\HttpCacheBundle\Configuration\Tag" now to avoid errors or add an explicit @return annotation to suppress this message. 

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good. i added two suggestions, can you check if you agree with these?

@XWB
Copy link
Member Author

XWB commented Aug 5, 2022

@dbu Done :)

@dbu dbu merged commit 0cb493d into FriendsOfSymfony:master Aug 6, 2022
@dbu
Copy link
Contributor

dbu commented Aug 6, 2022

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants