Add CloudFront support #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Apr 7, 2023
There was a problem hiding this comment.
thanks, good job! i added some suggestions to clarify the documentation.
can you please rebase on 2.x to get the CS fixes that have been needed? and add cloudfront to the spelling word list so the spellchecker is happy?
the ci runs tests with various old PHP versions. i suggest that we remove require-dev of your library and make your new test cases if (!class_exists(...)) {$this->markAsSkipped('jean-beru/fos-http-cache-cloudfront not available');}
and in the github action add a conditional step that only runs if php version is 8.1 or newer that composer require your library
Co-authored-by: David Buchmann <[email protected]>
Jean-Beru
force-pushed
the
add-cloudfront-support
branch
from
6458394 to
741f475
Compare
|
PR is rebased, dev-depencency is removed and CI is green 🎉 Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support of CloudFront proxy using https://github.com/Jean-Beru/fos-http-cache-cloudfront. See FriendsOfSymfony/FOSHttpCache#542.
This dependency is added in Composer as a "suggest" (and "dev" for testing purpose). We can also discuss about removing it by merging its classes in https://github.com/FriendsOfSymfony/FOSHttpCache.