Skip to content

Commit 19a9f40

Browse files
authored
Merge pull request #399 from derrabus/improvement/php-8
Add support for php 8
2 parents 9deaf91 + 0f9126b commit 19a9f40

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ matrix:
55
- php: 7.1
66
- php: 7.2
77
- php: 7.3
8-
- php: 7.4snapshot
8+
- php: 7.4
9+
- php: 8.0snapshot
910
- php: 7.1
1011
env: SYMFONY_VERSION='3.4.*'
1112
- php: 7.1

Extractor/ExposedRoutesExtractor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class ExposedRoutesExtractor implements ExposedRoutesExtractorInterface
5858
*
5959
* @throws \Exception
6060
*/
61-
public function __construct(RouterInterface $router, array $routesToExpose = array(), $cacheDir, $bundles = array())
61+
public function __construct(RouterInterface $router, array $routesToExpose, $cacheDir, $bundles = array())
6262
{
6363
$this->router = $router;
6464
$this->cacheDir = $cacheDir;

Tests/Command/RouterDebugExposedCommandTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ public function testExecute()
4949
$tester = new CommandTester($command);
5050
$tester->execute(array());
5151

52-
$this->assertRegExp('/literal(.*ANY){3}.*\/literal/', $tester->getDisplay());
53-
$this->assertRegExp('/blog_post(.*ANY){3}.*\/blog-post\/{slug}/', $tester->getDisplay());
54-
$this->assertRegExp('/list(.*ANY){3}.*\/literal/', $tester->getDisplay());
52+
$this->assertMatchesRegularExpression('/literal(.*ANY){3}.*\/literal/', $tester->getDisplay());
53+
$this->assertMatchesRegularExpression('/blog_post(.*ANY){3}.*\/blog-post\/{slug}/', $tester->getDisplay());
54+
$this->assertMatchesRegularExpression('/list(.*ANY){3}.*\/literal/', $tester->getDisplay());
5555
}
5656

5757
public function testExecuteWithNameUnknown()

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,15 @@
1616
}
1717
],
1818
"require": {
19-
"php": "^7.1",
19+
"php": "^7.1|^8.0",
2020
"symfony/framework-bundle": "~3.3|^4.0|^5.0",
2121
"symfony/serializer": "~3.3|^4.0|^5.0",
2222
"symfony/console": "~3.3|^4.0|^5.0",
2323
"willdurand/jsonp-callback-validator": "~1.0"
2424
},
2525
"require-dev": {
2626
"symfony/expression-language": "~3.3|^4.0|^5.0",
27-
"symfony/phpunit-bridge": "^3.3|^4.0"
27+
"symfony/phpunit-bridge": "^5.1"
2828
},
2929
"autoload": {
3030
"psr-4": { "FOS\\JsRoutingBundle\\": "" },

0 commit comments

Comments
 (0)