Skip to content

Commit 2a32afd

Browse files
[lldb] Remove more references to lldb-vscode (llvm#69696)
There are some uses of "vscode" in `lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py` where I'm not sure if it's referring to the adapter or VS Code itself, so those remain.
1 parent f5043f4 commit 2a32afd

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

lldb/CodeOwners.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,8 @@ lldb-server
234234
| Pavel Labath
235235
| pavel\@labath.sk (email), labath (Phabricator), labath (GitHub), labath (Discourse)
236236
237-
lldb-vscode
238-
~~~~~~~~~~~
237+
lldb-dap
238+
~~~~~~~~
239239
| Greg Clayton
240240
| gclayton\@fb.com (email), clayborg (Phabricator), clayborg (GitHub), clayborg (Discourse)
241241

lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def read_packet(f, verbose=False, trace_file=None):
8080
# Decode the JSON bytes into a python dictionary
8181
return json.loads(json_str)
8282

83-
raise Exception("unexpected malformed message from lldb-vscode: " + line)
83+
raise Exception("unexpected malformed message from lldb-dap: " + line)
8484

8585

8686
def packet_type_is(packet, packet_type):
@@ -104,7 +104,7 @@ def read_packet_thread(vs_comm, log_file):
104104
packet = read_packet(vs_comm.recv, trace_file=vs_comm.trace_file)
105105
# `packet` will be `None` on EOF. We want to pass it down to
106106
# handle_recv_packet anyway so the main thread can handle unexpected
107-
# termination of lldb-vscode and stop waiting for new packets.
107+
# termination of lldb-dap and stop waiting for new packets.
108108
done = not vs_comm.handle_recv_packet(packet)
109109
finally:
110110
dump_dap_log(log_file)
@@ -1172,7 +1172,7 @@ def main():
11721172
dest="debuggerRoot",
11731173
default=None,
11741174
help=(
1175-
"Set the working directory for lldb-vscode for any object files "
1175+
"Set the working directory for lldb-dap for any object files "
11761176
"with relative paths in the Mach-o debug map."
11771177
),
11781178
)
@@ -1203,7 +1203,7 @@ def main():
12031203
action="store_true",
12041204
dest="sourceInitFile",
12051205
default=False,
1206-
help="Whether lldb-vscode should source .lldbinit file or not",
1206+
help="Whether lldb-dap should source .lldbinit file or not",
12071207
)
12081208

12091209
parser.add_option(
@@ -1360,7 +1360,7 @@ def main():
13601360
print(
13611361
"error: must either specify a path to a Visual Studio Code "
13621362
"Debug Adaptor vscode executable path using the --vscode "
1363-
"option, or a port to attach to for an existing lldb-vscode "
1363+
"option, or a port to attach to for an existing lldb-dap "
13641364
"using the --port option"
13651365
)
13661366
return

lldb/test/API/lit.cfg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def delete_module_cache(path):
248248
"lldb-repro-capture" in config.available_features
249249
or "lldb-repro-replay" in config.available_features
250250
):
251-
dotest_cmd += ["--skip-category=lldb-vscode", "--skip-category=std-module"]
251+
dotest_cmd += ["--skip-category=lldb-dap", "--skip-category=std-module"]
252252

253253
if "lldb-simulator-ios" in config.available_features:
254254
dotest_cmd += ["--apple-sdk", "iphonesimulator", "--platform-name", "ios-simulator"]

lldb/test/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ if(TARGET lldb-server)
114114
add_lldb_test_dependency(lldb-server)
115115
endif()
116116

117-
if(TARGET lldb-vscode)
118-
add_lldb_test_dependency(lldb-vscode)
117+
if(TARGET lldb-dap)
118+
add_lldb_test_dependency(lldb-dap)
119119
endif()
120120

121121
if(TARGET liblldb)

lldb/tools/lldb-dap/lldb-dap.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,9 @@ static constexpr llvm::opt::OptTable::Info InfoTable[] = {
9797
#include "Options.inc"
9898
#undef OPTION
9999
};
100-
class LLDBVSCodeOptTable : public llvm::opt::GenericOptTable {
100+
class LLDBDAPOptTable : public llvm::opt::GenericOptTable {
101101
public:
102-
LLDBVSCodeOptTable() : llvm::opt::GenericOptTable(InfoTable, true) {}
102+
LLDBDAPOptTable() : llvm::opt::GenericOptTable(InfoTable, true) {}
103103
};
104104

105105
typedef void (*RequestCallback)(const llvm::json::Object &command);
@@ -3569,9 +3569,9 @@ void RegisterRequestCallbacks() {
35693569

35703570
} // anonymous namespace
35713571

3572-
static void printHelp(LLDBVSCodeOptTable &table, llvm::StringRef tool_name) {
3572+
static void printHelp(LLDBDAPOptTable &table, llvm::StringRef tool_name) {
35733573
std::string usage_str = tool_name.str() + " options";
3574-
table.printHelp(llvm::outs(), usage_str.c_str(), "LLDB VSCode", false);
3574+
table.printHelp(llvm::outs(), usage_str.c_str(), "LLDB DAP", false);
35753575

35763576
std::string examples = R"___(
35773577
EXAMPLES:
@@ -3706,7 +3706,7 @@ int main(int argc, char *argv[]) {
37063706
llvm::sys::fs::make_absolute(program_path);
37073707
g_dap.debug_adaptor_path = program_path.str().str();
37083708

3709-
LLDBVSCodeOptTable T;
3709+
LLDBDAPOptTable T;
37103710
unsigned MAI, MAC;
37113711
llvm::ArrayRef<const char *> ArgsArr = llvm::ArrayRef(argv + 1, argc);
37123712
llvm::opt::InputArgList input_args = T.ParseArgs(ArgsArr, MAI, MAC);

0 commit comments

Comments
 (0)