Skip to content

Commit 461918e

Browse files
authored
[CodeGen][Remarks] Add the function name to the stack size remark (llvm#69346)
It is already present in the yaml, but missing from the printed diagnostics.
1 parent a9136f0 commit 461918e

File tree

3 files changed

+21
-7
lines changed

3 files changed

+21
-7
lines changed

llvm/lib/CodeGen/PrologEpilogInserter.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,9 @@ bool PEI::runOnMachineFunction(MachineFunction &MF) {
337337
return MachineOptimizationRemarkAnalysis(DEBUG_TYPE, "StackSize",
338338
MF.getFunction().getSubprogram(),
339339
&MF.front())
340-
<< ore::NV("NumStackBytes", StackSize) << " stack bytes in function";
340+
<< ore::NV("NumStackBytes", StackSize)
341+
<< " stack bytes in function '"
342+
<< ore::NV("Function", MF.getFunction().getName()) << "'";
341343
});
342344

343345
delete RS;

llvm/test/CodeGen/AArch64/prologue-epilogue-remarks.mir

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ stack:
1111
# CHECK: Function: fun0
1212
# CHECK-NEXT: Args:
1313
# CHECK-NEXT: - NumStackBytes: '16'
14-
# CHECK-NEXT: - String: ' stack bytes in function'
14+
# CHECK-NEXT: - String: ' stack bytes in function '''
15+
# CHECK-NEXT: - Function: fun0
16+
# CHECK-NEXT: - String: ''''
1517
# CHECK-NEXT: ...
1618
constants:
1719
body: |
@@ -29,7 +31,9 @@ stack:
2931
# CHECK: Function: fun1
3032
# CHECK-NEXT: Args:
3133
# CHECK-NEXT: - NumStackBytes: '32'
32-
# CHECK-NEXT: - String: ' stack bytes in function'
34+
# CHECK-NEXT: - String: ' stack bytes in function '''
35+
# CHECK-NEXT: - Function: fun1
36+
# CHECK-NEXT: - String: ''''
3337
# CHECK-NEXT: ...
3438
constants:
3539
body: |
@@ -47,7 +51,9 @@ stack:
4751
# CHECK: Function: fun2
4852
# CHECK-NEXT: Args:
4953
# CHECK-NEXT: - NumStackBytes: '1040'
50-
# CHECK-NEXT: - String: ' stack bytes in function'
54+
# CHECK-NEXT: - String: ' stack bytes in function '''
55+
# CHECK-NEXT: - Function: fun2
56+
# CHECK-NEXT: - String: ''''
5157
# CHECK-NEXT: ...
5258
constants:
5359
body: |

llvm/test/CodeGen/X86/prologue-epilogue-remarks.mir

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ stack:
1717
# CHECK-NEXT: Function: fun0
1818
# CHECK-NEXT: Args:
1919
# CHECK-NEXT: - NumStackBytes: '8'
20-
# CHECK-NEXT: - String: ' stack bytes in function'
20+
# CHECK-NEXT: - String: ' stack bytes in function '''
21+
# CHECK-NEXT: - Function: fun0
22+
# CHECK-NEXT: - String: ''''
2123
# CHECK-NEXT: ...
2224

2325
constants:
@@ -36,7 +38,9 @@ stack:
3638
# CHECK-NEXT: Function: fun1
3739
# CHECK-NEXT: Args:
3840
# CHECK-NEXT: - NumStackBytes: '20'
39-
# CHECK-NEXT: - String: ' stack bytes in function'
41+
# CHECK-NEXT: - String: ' stack bytes in function '''
42+
# CHECK-NEXT: - Function: fun1
43+
# CHECK-NEXT: - String: ''''
4044
# CHECK-NEXT: ...
4145
constants:
4246
body: |
@@ -54,7 +58,9 @@ stack:
5458
# CHECK-NEXT: Function: fun2
5559
# CHECK-NEXT: Args:
5660
# CHECK-NEXT: - NumStackBytes: '1024'
57-
# CHECK-NEXT: - String: ' stack bytes in function'
61+
# CHECK-NEXT: - String: ' stack bytes in function '''
62+
# CHECK-NEXT: - Function: fun2
63+
# CHECK-NEXT: - String: ''''
5864
# CHECK-NEXT: ...
5965
constants:
6066
body: |

0 commit comments

Comments
 (0)