Skip to content

Commit a3754ad

Browse files
authored
[NFC][LLVM][AMDGPU] Cleanup pass initialization for AMDGPU (llvm#134410)
- Remove calls to pass initialization from pass constructors. - llvm#111767
1 parent 1356e20 commit a3754ad

24 files changed

+30
-99
lines changed

llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@ ImmutablePass *llvm::createAMDGPUExternalAAWrapperPass() {
3838
return new AMDGPUExternalAAWrapper();
3939
}
4040

41-
AMDGPUAAWrapperPass::AMDGPUAAWrapperPass() : ImmutablePass(ID) {
42-
initializeAMDGPUAAWrapperPassPass(*PassRegistry::getPassRegistry());
43-
}
41+
AMDGPUAAWrapperPass::AMDGPUAAWrapperPass() : ImmutablePass(ID) {}
4442

4543
void AMDGPUAAWrapperPass::getAnalysisUsage(AnalysisUsage &AU) const {
4644
AU.setPreservesAll();

llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,12 @@
1717
#include "llvm/CodeGen/TargetPassConfig.h"
1818
#include "llvm/IR/IntrinsicsAMDGPU.h"
1919
#include "llvm/IR/IntrinsicsR600.h"
20+
#include "llvm/InitializePasses.h"
2021
#include "llvm/Target/TargetMachine.h"
2122
#include "llvm/Transforms/IPO/Attributor.h"
2223

2324
#define DEBUG_TYPE "amdgpu-attributor"
2425

25-
namespace llvm {
26-
void initializeCycleInfoWrapperPassPass(PassRegistry &);
27-
} // namespace llvm
28-
2926
using namespace llvm;
3027

3128
static cl::opt<unsigned> KernargPreloadCount(

llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -336,9 +336,7 @@ class AMDGPUCodeGenPrepareImpl
336336
class AMDGPUCodeGenPrepare : public FunctionPass {
337337
public:
338338
static char ID;
339-
AMDGPUCodeGenPrepare() : FunctionPass(ID) {
340-
initializeAMDGPUCodeGenPreparePass(*PassRegistry::getPassRegistry());
341-
}
339+
AMDGPUCodeGenPrepare() : FunctionPass(ID) {}
342340
void getAnalysisUsage(AnalysisUsage &AU) const override {
343341
AU.addRequired<AssumptionCacheTracker>();
344342
AU.addRequired<UniformityInfoWrapperPass>();

llvm/lib/Target/AMDGPU/AMDGPUExportClustering.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,7 @@ void ExportClustering::apply(ScheduleDAGInstrs *DAG) {
139139

140140
} // end namespace
141141

142-
namespace llvm {
143-
144-
std::unique_ptr<ScheduleDAGMutation> createAMDGPUExportClusteringDAGMutation() {
142+
std::unique_ptr<ScheduleDAGMutation>
143+
llvm::createAMDGPUExportClusteringDAGMutation() {
145144
return std::make_unique<ExportClustering>();
146145
}
147-
148-
} // end namespace llvm

llvm/lib/Target/AMDGPU/AMDGPUGlobalISelDivergenceLowering.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,7 @@ class AMDGPUGlobalISelDivergenceLowering : public MachineFunctionPass {
3434
static char ID;
3535

3636
public:
37-
AMDGPUGlobalISelDivergenceLowering() : MachineFunctionPass(ID) {
38-
initializeAMDGPUGlobalISelDivergenceLoweringPass(
39-
*PassRegistry::getPassRegistry());
40-
}
37+
AMDGPUGlobalISelDivergenceLowering() : MachineFunctionPass(ID) {}
4138

4239
bool runOnMachineFunction(MachineFunction &MF) override;
4340

llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2696,16 +2696,12 @@ bool IGroupLPDAGMutation::initIGLPOpt(SUnit &SU) {
26962696

26972697
} // namespace
26982698

2699-
namespace llvm {
2700-
27012699
/// \p Phase specifes whether or not this is a reentry into the
27022700
/// IGroupLPDAGMutation. Since there may be multiple scheduling passes on the
27032701
/// same scheduling region (e.g. pre and post-RA scheduling / multiple
27042702
/// scheduling "phases"), we can reenter this mutation framework more than once
27052703
/// for a given region.
27062704
std::unique_ptr<ScheduleDAGMutation>
2707-
createIGroupLPDAGMutation(AMDGPU::SchedulingPhase Phase) {
2705+
llvm::createIGroupLPDAGMutation(AMDGPU::SchedulingPhase Phase) {
27082706
return std::make_unique<IGroupLPDAGMutation>(Phase);
27092707
}
2710-
2711-
} // end namespace llvm

llvm/lib/Target/AMDGPU/AMDGPULowerBufferFatPointers.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2312,10 +2312,7 @@ class AMDGPULowerBufferFatPointers : public ModulePass {
23122312
public:
23132313
static char ID;
23142314

2315-
AMDGPULowerBufferFatPointers() : ModulePass(ID) {
2316-
initializeAMDGPULowerBufferFatPointersPass(
2317-
*PassRegistry::getPassRegistry());
2318-
}
2315+
AMDGPULowerBufferFatPointers() : ModulePass(ID) {}
23192316

23202317
bool run(Module &M, const TargetMachine &TM);
23212318
bool runOnModule(Module &M) override;

llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1502,10 +1502,8 @@ class AMDGPULowerModuleLDSLegacy : public ModulePass {
15021502
const AMDGPUTargetMachine *TM;
15031503
static char ID;
15041504

1505-
AMDGPULowerModuleLDSLegacy(const AMDGPUTargetMachine *TM_ = nullptr)
1506-
: ModulePass(ID), TM(TM_) {
1507-
initializeAMDGPULowerModuleLDSLegacyPass(*PassRegistry::getPassRegistry());
1508-
}
1505+
AMDGPULowerModuleLDSLegacy(const AMDGPUTargetMachine *TM = nullptr)
1506+
: ModulePass(ID), TM(TM) {}
15091507

15101508
void getAnalysisUsage(AnalysisUsage &AU) const override {
15111509
if (!TM)

llvm/lib/Target/AMDGPU/AMDGPUMachineModuleInfo.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#include "AMDGPUMachineModuleInfo.h"
1616
#include "llvm/IR/Module.h"
1717

18-
namespace llvm {
18+
using namespace llvm;
1919

2020
AMDGPUMachineModuleInfo::AMDGPUMachineModuleInfo(const MachineModuleInfo &MMI)
2121
: MachineModuleInfoELF(MMI) {
@@ -34,5 +34,3 @@ AMDGPUMachineModuleInfo::AMDGPUMachineModuleInfo(const MachineModuleInfo &MMI)
3434
SingleThreadOneAddressSpaceSSID =
3535
CTX.getOrInsertSyncScopeID("singlethread-one-as");
3636
}
37-
38-
} // end namespace llvm

llvm/lib/Target/AMDGPU/AMDGPUMarkLastScratchLoad.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,7 @@ class AMDGPUMarkLastScratchLoadLegacy : public MachineFunctionPass {
4242
public:
4343
static char ID;
4444

45-
AMDGPUMarkLastScratchLoadLegacy() : MachineFunctionPass(ID) {
46-
initializeAMDGPUMarkLastScratchLoadLegacyPass(
47-
*PassRegistry::getPassRegistry());
48-
}
45+
AMDGPUMarkLastScratchLoadLegacy() : MachineFunctionPass(ID) {}
4946

5047
bool runOnMachineFunction(MachineFunction &MF) override;
5148

llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -473,8 +473,6 @@ void AMDGPUPostLegalizerCombiner::getAnalysisUsage(AnalysisUsage &AU) const {
473473

474474
AMDGPUPostLegalizerCombiner::AMDGPUPostLegalizerCombiner(bool IsOptNone)
475475
: MachineFunctionPass(ID), IsOptNone(IsOptNone) {
476-
initializeAMDGPUPostLegalizerCombinerPass(*PassRegistry::getPassRegistry());
477-
478476
if (!RuleConfig.parseCommandLineOption())
479477
report_fatal_error("Invalid rule identifier");
480478
}
@@ -519,8 +517,6 @@ INITIALIZE_PASS_END(AMDGPUPostLegalizerCombiner, DEBUG_TYPE,
519517
"Combine AMDGPU machine instrs after legalization", false,
520518
false)
521519

522-
namespace llvm {
523-
FunctionPass *createAMDGPUPostLegalizeCombiner(bool IsOptNone) {
520+
FunctionPass *llvm::createAMDGPUPostLegalizeCombiner(bool IsOptNone) {
524521
return new AMDGPUPostLegalizerCombiner(IsOptNone);
525522
}
526-
} // end namespace llvm

llvm/lib/Target/AMDGPU/AMDGPUPreLegalizerCombiner.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -248,8 +248,6 @@ void AMDGPUPreLegalizerCombiner::getAnalysisUsage(AnalysisUsage &AU) const {
248248

249249
AMDGPUPreLegalizerCombiner::AMDGPUPreLegalizerCombiner(bool IsOptNone)
250250
: MachineFunctionPass(ID), IsOptNone(IsOptNone) {
251-
initializeAMDGPUPreLegalizerCombinerPass(*PassRegistry::getPassRegistry());
252-
253251
if (!RuleConfig.parseCommandLineOption())
254252
report_fatal_error("Invalid rule identifier");
255253
}
@@ -296,8 +294,6 @@ INITIALIZE_PASS_END(AMDGPUPreLegalizerCombiner, DEBUG_TYPE,
296294
"Combine AMDGPU machine instrs before legalization", false,
297295
false)
298296

299-
namespace llvm {
300-
FunctionPass *createAMDGPUPreLegalizeCombiner(bool IsOptNone) {
297+
FunctionPass *llvm::createAMDGPUPreLegalizeCombiner(bool IsOptNone) {
301298
return new AMDGPUPreLegalizerCombiner(IsOptNone);
302299
}
303-
} // end namespace llvm

llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class AMDGPUPrintfRuntimeBinding final : public ModulePass {
4242
public:
4343
static char ID;
4444

45-
explicit AMDGPUPrintfRuntimeBinding();
45+
explicit AMDGPUPrintfRuntimeBinding() : ModulePass(ID) {}
4646

4747
private:
4848
bool runOnModule(Module &M) override;
@@ -76,15 +76,9 @@ INITIALIZE_PASS_END(AMDGPUPrintfRuntimeBinding, "amdgpu-printf-runtime-binding",
7676

7777
char &llvm::AMDGPUPrintfRuntimeBindingID = AMDGPUPrintfRuntimeBinding::ID;
7878

79-
namespace llvm {
80-
ModulePass *createAMDGPUPrintfRuntimeBinding() {
79+
ModulePass *llvm::createAMDGPUPrintfRuntimeBinding() {
8180
return new AMDGPUPrintfRuntimeBinding();
8281
}
83-
} // namespace llvm
84-
85-
AMDGPUPrintfRuntimeBinding::AMDGPUPrintfRuntimeBinding() : ModulePass(ID) {
86-
initializeAMDGPUPrintfRuntimeBindingPass(*PassRegistry::getPassRegistry());
87-
}
8882

8983
void AMDGPUPrintfRuntimeBindingImpl::getConversionSpecifiers(
9084
SmallVectorImpl<char> &OpConvSpecifiers, StringRef Fmt,

llvm/lib/Target/AMDGPU/AMDGPURegBankCombiner.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -427,8 +427,6 @@ void AMDGPURegBankCombiner::getAnalysisUsage(AnalysisUsage &AU) const {
427427

428428
AMDGPURegBankCombiner::AMDGPURegBankCombiner(bool IsOptNone)
429429
: MachineFunctionPass(ID), IsOptNone(IsOptNone) {
430-
initializeAMDGPURegBankCombinerPass(*PassRegistry::getPassRegistry());
431-
432430
if (!RuleConfig.parseCommandLineOption())
433431
report_fatal_error("Invalid rule identifier");
434432
}
@@ -473,8 +471,6 @@ INITIALIZE_PASS_END(AMDGPURegBankCombiner, DEBUG_TYPE,
473471
"Combine AMDGPU machine instrs after regbankselect", false,
474472
false)
475473

476-
namespace llvm {
477-
FunctionPass *createAMDGPURegBankCombiner(bool IsOptNone) {
474+
FunctionPass *llvm::createAMDGPURegBankCombiner(bool IsOptNone) {
478475
return new AMDGPURegBankCombiner(IsOptNone);
479476
}
480-
} // end namespace llvm

llvm/lib/Target/AMDGPU/AMDGPURegBankLegalize.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,7 @@ class AMDGPURegBankLegalize : public MachineFunctionPass {
4040
static char ID;
4141

4242
public:
43-
AMDGPURegBankLegalize() : MachineFunctionPass(ID) {
44-
initializeAMDGPURegBankLegalizePass(*PassRegistry::getPassRegistry());
45-
}
43+
AMDGPURegBankLegalize() : MachineFunctionPass(ID) {}
4644

4745
bool runOnMachineFunction(MachineFunction &MF) override;
4846

llvm/lib/Target/AMDGPU/AMDGPURegBankSelect.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ class AMDGPURegBankSelect : public MachineFunctionPass {
3535
public:
3636
static char ID;
3737

38-
AMDGPURegBankSelect() : MachineFunctionPass(ID) {
39-
initializeAMDGPURegBankSelectPass(*PassRegistry::getPassRegistry());
40-
}
38+
AMDGPURegBankSelect() : MachineFunctionPass(ID) {}
4139

4240
bool runOnMachineFunction(MachineFunction &MF) override;
4341

llvm/lib/Target/AMDGPU/AMDGPUReserveWWMRegs.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ class AMDGPUReserveWWMRegsLegacy : public MachineFunctionPass {
3232
public:
3333
static char ID;
3434

35-
AMDGPUReserveWWMRegsLegacy() : MachineFunctionPass(ID) {
36-
initializeAMDGPUReserveWWMRegsLegacyPass(*PassRegistry::getPassRegistry());
37-
}
35+
AMDGPUReserveWWMRegsLegacy() : MachineFunctionPass(ID) {}
3836

3937
bool runOnMachineFunction(MachineFunction &MF) override;
4038

llvm/lib/Target/AMDGPU/AMDGPURewriteUndefForPHI.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@ namespace {
7272
class AMDGPURewriteUndefForPHILegacy : public FunctionPass {
7373
public:
7474
static char ID;
75-
AMDGPURewriteUndefForPHILegacy() : FunctionPass(ID) {
76-
initializeAMDGPURewriteUndefForPHILegacyPass(*PassRegistry::getPassRegistry());
77-
}
75+
AMDGPURewriteUndefForPHILegacy() : FunctionPass(ID) {}
7876
bool runOnFunction(Function &F) override;
7977
StringRef getPassName() const override {
8078
return "AMDGPU Rewrite Undef for PHI";

llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,9 +1285,7 @@ class AMDGPUSwLowerLDSLegacy : public ModulePass {
12851285
const AMDGPUTargetMachine *AMDGPUTM;
12861286
static char ID;
12871287
AMDGPUSwLowerLDSLegacy(const AMDGPUTargetMachine *TM)
1288-
: ModulePass(ID), AMDGPUTM(TM) {
1289-
initializeAMDGPUSwLowerLDSLegacyPass(*PassRegistry::getPassRegistry());
1290-
}
1288+
: ModulePass(ID), AMDGPUTM(TM) {}
12911289
bool runOnModule(Module &M) override;
12921290
void getAnalysisUsage(AnalysisUsage &AU) const override {
12931291
AU.addPreserved<DominatorTreeWrapperPass>();

llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -489,6 +489,8 @@ extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeAMDGPUTarget() {
489489
initializeR600PacketizerPass(*PR);
490490
initializeR600ExpandSpecialInstrsPassPass(*PR);
491491
initializeR600VectorRegMergerPass(*PR);
492+
initializeR600EmitClauseMarkersPass(*PR);
493+
initializeR600MachineCFGStructurizerPass(*PR);
492494
initializeGlobalISel(*PR);
493495
initializeAMDGPUDAGToDAGISelLegacyPass(*PR);
494496
initializeGCNDPPCombineLegacyPass(*PR);

llvm/lib/Target/AMDGPU/AMDGPUUnifyDivergentExitNodes.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,7 @@ class AMDGPUUnifyDivergentExitNodesImpl {
7474
class AMDGPUUnifyDivergentExitNodes : public FunctionPass {
7575
public:
7676
static char ID;
77-
AMDGPUUnifyDivergentExitNodes() : FunctionPass(ID) {
78-
initializeAMDGPUUnifyDivergentExitNodesPass(
79-
*PassRegistry::getPassRegistry());
80-
}
77+
AMDGPUUnifyDivergentExitNodes() : FunctionPass(ID) {}
8178
void getAnalysisUsage(AnalysisUsage &AU) const override;
8279
bool runOnFunction(Function &F) override;
8380
};

llvm/lib/Target/AMDGPU/R600.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ extern char &R600VectorRegMergerID;
4545
void initializeR600PacketizerPass(PassRegistry &);
4646
extern char &R600PacketizerID;
4747

48+
void initializeR600EmitClauseMarkersPass(PassRegistry &);
49+
void initializeR600MachineCFGStructurizerPass(PassRegistry &);
50+
4851
} // End namespace llvm
4952

5053
#endif

llvm/lib/Target/AMDGPU/R600EmitClauseMarkers.cpp

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,6 @@
2121

2222
using namespace llvm;
2323

24-
namespace llvm {
25-
26-
void initializeR600EmitClauseMarkersPass(PassRegistry&);
27-
28-
} // end namespace llvm
29-
3024
namespace {
3125

3226
class R600EmitClauseMarkers : public MachineFunctionPass {
@@ -289,9 +283,7 @@ class R600EmitClauseMarkers : public MachineFunctionPass {
289283
public:
290284
static char ID;
291285

292-
R600EmitClauseMarkers() : MachineFunctionPass(ID) {
293-
initializeR600EmitClauseMarkersPass(*PassRegistry::getPassRegistry());
294-
}
286+
R600EmitClauseMarkers() : MachineFunctionPass(ID) {}
295287

296288
bool runOnMachineFunction(MachineFunction &MF) override {
297289
const R600Subtarget &ST = MF.getSubtarget<R600Subtarget>();

llvm/lib/Target/AMDGPU/R600MachineCFGStructurizer.cpp

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,6 @@ STATISTIC(numIfPatternMatch, "CFGStructurizer number of if pattern "
4141
STATISTIC(numClonedBlock, "CFGStructurizer cloned blocks");
4242
STATISTIC(numClonedInstr, "CFGStructurizer cloned instructions");
4343

44-
namespace llvm {
45-
46-
void initializeR600MachineCFGStructurizerPass(PassRegistry &);
47-
48-
} // end namespace llvm
49-
5044
namespace {
5145

5246
//===----------------------------------------------------------------------===//
@@ -104,9 +98,7 @@ class R600MachineCFGStructurizer : public MachineFunctionPass {
10498

10599
static char ID;
106100

107-
R600MachineCFGStructurizer() : MachineFunctionPass(ID) {
108-
initializeR600MachineCFGStructurizerPass(*PassRegistry::getPassRegistry());
109-
}
101+
R600MachineCFGStructurizer() : MachineFunctionPass(ID) {}
110102

111103
StringRef getPassName() const override {
112104
return "AMDGPU Control Flow Graph structurizer Pass";

0 commit comments

Comments
 (0)