Skip to content

Commit ae15f5c

Browse files
SC llvm teamSC llvm team
authored andcommitted
Merged main:0916ae49b89db6eb9eee9f6fee4f1a65fd9cdb74 into amd-gfx:b0eb828c0946
Local branch amd-gfx b0eb828 Merged main:6bc225e0630f28e83290a43c3d9b25b057fc815a into amd-gfx:4bb4bb5b239f Remote branch main 0916ae4 [clang-format] Fix a misannotation of less/greater as angle brackets (llvm#105941)
2 parents b0eb828 + 0916ae4 commit ae15f5c

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

clang/lib/Format/TokenAnnotator.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ class AnnotatingParser {
250250
if (Precedence > prec::Conditional && Precedence < prec::Relational)
251251
return false;
252252
}
253-
if (Prev.is(TT_ConditionalExpr))
253+
if (Prev.isOneOf(tok::question, tok::colon) && !Style.isProto())
254254
SeenTernaryOperator = true;
255255
updateParameterCount(Left, CurrentToken);
256256
if (Style.Language == FormatStyle::LK_Proto) {

clang/unittests/Format/TokenAnnotatorTest.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -620,6 +620,11 @@ TEST_F(TokenAnnotatorTest, UnderstandsNonTemplateAngleBrackets) {
620620
EXPECT_TOKEN(Tokens[2], tok::less, TT_BinaryOperator);
621621
EXPECT_TOKEN(Tokens[8], tok::greater, TT_BinaryOperator);
622622

623+
Tokens = annotate("return checklower ? a < b : a > b;");
624+
ASSERT_EQ(Tokens.size(), 12u) << Tokens;
625+
EXPECT_TOKEN(Tokens[4], tok::less, TT_BinaryOperator);
626+
EXPECT_TOKEN(Tokens[8], tok::greater, TT_BinaryOperator);
627+
623628
Tokens = annotate("return A < B ^ A > B;");
624629
ASSERT_EQ(Tokens.size(), 10u) << Tokens;
625630
EXPECT_TOKEN(Tokens[2], tok::less, TT_BinaryOperator);

llvm/include/llvm/Config/llvm-config.h.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
/* Indicate that this is LLVM compiled from the amd-gfx branch. */
1818
#define LLVM_HAVE_BRANCH_AMD_GFX
19-
#define LLVM_MAIN_REVISION 509550
19+
#define LLVM_MAIN_REVISION 509551
2020

2121
/* Define if LLVM_ENABLE_DUMP is enabled */
2222
#cmakedefine LLVM_ENABLE_DUMP

0 commit comments

Comments
 (0)