Skip to content

Commit 1b49eb1

Browse files
authored
Merge pull request ember-learn#563 from rwjblue/lint-markdown
Lint markdown in CI (and fix linting issues).
2 parents 50e16d7 + 1587763 commit 1b49eb1

File tree

4 files changed

+19
-5
lines changed

4 files changed

+19
-5
lines changed

.local.dic

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ Ctrl-C
2727
customizations
2828
D3
2929
dasherize
30+
DataAdapter
3031
datepicker
3132
de
3233
debounce
@@ -36,6 +37,7 @@ deserializing
3637
draggable
3738
durations
3839
enumerables
40+
ember-a11y
3941
ember-cli-deprecation-workflow
4042
ember-cli-cjs-transform
4143
ember-cli-mirage.
@@ -46,13 +48,15 @@ erroring
4648
Evented
4749
facto
4850
falsy
51+
focusable
4952
frontend
5053
fullname
5154
geocode
5255
geocoding
5356
Geolocation
5457
globbing
5558
*google
59+
HammerJS
5660
hardcode
5761
hashchange
5862
Hoc
@@ -74,6 +78,8 @@ modularity
7478
naïve
7579
nav
7680
*NPM
81+
NVDA
82+
Orca
7783
Param
7884
param
7985
params
@@ -88,6 +94,7 @@ prepend
8894
pre-transition
8995
readme
9096
readonly
97+
recognizers
9198
relayout
9299
repo
93100
rerender
@@ -108,12 +115,18 @@ subexpression
108115
suboptimal
109116
substate
110117
substates
118+
syntaxes
119+
TalkBack
111120
teardown
112121
templating
113122
todo
114123
todos
115124
typeahead
125+
UIs
116126
unsilence
117127
untrusted
118128
usecase
119-
viewport
129+
viewport
130+
VoiceOver
131+
WAI-ARIA
132+
WCAG

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,5 @@ before_install:
2929
script:
3030
- npm run lint:hbs
3131
- npm run lint:js
32+
- npm run lint:md
3233
- npm test

guides/release/reference/accessibility-guide.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ Here is a checklist of some things to keep in mind when developing your applicat
6767
- All interactive elements must be usable with only a keyboard. A helpful development tip- make sure you can use your own app just using your keyboard.
6868
- Do not use `role="presentation"` or `aria-hidden="true"` on a focusable element.
6969
- All interactive elements must have an accessible name.
70-
- The values for the role attribute are pre-defined by the ARIA specification. This is not something an author can define a custom value for (that is not listed in the spec). [Learn more about roles in the specification.](https://www.w3.org/TR/wai-aria/#roles_categorization)
70+
- The values for the role attribute are predefined by the ARIA specification. This is not something an author can define a custom value for (that is not listed in the spec). [Learn more about roles in the specification.](https://www.w3.org/TR/wai-aria/#roles_categorization)
7171
- In general, avoid making your own keyboard shortcuts. [Screen readers already provide quite a few.](https://dequeuniversity.com/screenreaders/) There is some nuance here, so proceed with caution should you choose to do so.
72-
- "Completely accessible" may be somewhat of a misnomer. Practical accessibility looks more like 90% coding to the spec and 10% filing browser bugs (or keeping track of existing browser bugs). Keep in mind that if you choose to implement a workaround for a browser bug, you will need to to put an issue in your product backlog to follow up on browser bugs at a later date.
72+
- "Completely accessible" may be somewhat of a misnomer. Practical accessibility looks more like 90% coding to the spec and 10% filing browser bugs (or keeping track of existing browser bugs). Keep in mind that if you choose to implement a workaround for a browser bug, you will need to put an issue in your product backlog to follow up on browser bugs at a later date.
7373

7474
### Focus
7575

guides/v3.7.0/reference/accessibility-guide.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ Here is a checklist of some things to keep in mind when developing your applicat
6767
- All interactive elements must be usable with only a keyboard. A helpful development tip- make sure you can use your own app just using your keyboard.
6868
- Do not use `role="presentation"` or `aria-hidden="true"` on a focusable element.
6969
- All interactive elements must have an accessible name.
70-
- The values for the role attribute are pre-defined by the ARIA specification. This is not something an author can define a custom value for (that is not listed in the spec). [Learn more about roles in the specification.](https://www.w3.org/TR/wai-aria/#roles_categorization)
70+
- The values for the role attribute are predefined by the ARIA specification. This is not something an author can define a custom value for (that is not listed in the spec). [Learn more about roles in the specification.](https://www.w3.org/TR/wai-aria/#roles_categorization)
7171
- In general, avoid making your own keyboard shortcuts. [Screen readers already provide quite a few.](https://dequeuniversity.com/screenreaders/) There is some nuance here, so proceed with caution should you choose to do so.
72-
- "Completely accessible" may be somewhat of a misnomer. Practical accessibility looks more like 90% coding to the spec and 10% filing browser bugs (or keeping track of existing browser bugs). Keep in mind that if you choose to implement a workaround for a browser bug, you will need to to put an issue in your product backlog to follow up on browser bugs at a later date.
72+
- "Completely accessible" may be somewhat of a misnomer. Practical accessibility looks more like 90% coding to the spec and 10% filing browser bugs (or keeping track of existing browser bugs). Keep in mind that if you choose to implement a workaround for a browser bug, you will need to put an issue in your product backlog to follow up on browser bugs at a later date.
7373

7474
### Focus
7575

0 commit comments

Comments
 (0)