Skip to content

Commit 6be1de5

Browse files
committed
add labels to form input example
1 parent c8f017e commit 6be1de5

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

guides/release/upgrading/editions.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1783,13 +1783,15 @@ bindings will not work:
17831783
This does not work, since @value is
17841784
an argument and is immutable
17851785
-->
1786-
<Input @value={{@value}} />
1786+
<label for="title">Title</label>
1787+
<Input @value={{@value}} id="title" />
17871788
17881789
<!--
17891790
Instead, we should update the value
17901791
by passing an _action_ to the component
17911792
-->
1792-
<Input @value={{@value}} @key-up={{@updateValue}} />
1793+
<label for="title">Title</label>
1794+
<Input @value={{@value}} @key-up={{@updateValue}} id="title" />
17931795
```
17941796

17951797
Additionally, the `mut` helper generally can't be used for the same reason:

0 commit comments

Comments
 (0)