Skip to content

Commit 83beb0c

Browse files
authored
Merge pull request ember-learn#796 from ember-learn/octane-revisions
Revising the Octane Upgrade Guide
2 parents 2d4cd3b + 2bb5f66 commit 83beb0c

File tree

3 files changed

+247
-324
lines changed

3 files changed

+247
-324
lines changed

guides/release/components/defining-a-component.md

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -285,9 +285,7 @@ export default class BlogPost extends Component {}
285285
> You may notice that we're importing the component from `@glimmer` instead of
286286
> `@ember`. The Glimmer VM is the underlying rendering engine in Ember, and
287287
> Glimmer.js is a minimal component framework built on top of the Glimmer VM.
288-
> Ember and Glimmer.js use the same component class, which allows you to share
289-
> code between Ember and Glimmer.js apps. For more details on Glimmer.js, check
290-
> out [its documentation](https://glimmerjs.com/)
288+
> Although components are imported from this outside library, you don't need worry about learning Glimmer separately from Ember.
291289
292290
You can add methods and fields to the component, and then access them from the
293291
component's template. For instance, we could add the `sectionClass` property
@@ -371,19 +369,18 @@ Events](../actions-and-events).
371369

372370
#### Component Hooks and Properties
373371

374-
Components have the following class signature (this given as a TypeScript class
375-
signature for clarity and brevity, if you don't know TypeScript, don't worry!
376-
We'll explain what it all means in just a minute):
372+
Components have a very small class signature:
377373

378-
```js
374+
```js
379375
class GlimmerComponent {
380-
args: object;
376+
isDestroying = false;
377+
isDestroyed = false;
381378

382-
isDestroying: boolean;
383-
isDestroyed: boolean;
379+
constructor(owner, args) {
380+
this.args = args;
381+
}
384382

385-
constructor(owner: unknown, args: object);
386-
willDestroy();
383+
willDestroy() {}
387384
}
388385
```
389386

guides/release/state-management/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ in a popup, the page you're on, or the color of a button, Ember needs to respond
4848
to that change!
4949

5050
Ember's primary system for detecting changes to state is _tracked properties_.
51-
If you read the section on Glimmer components, you'll probably recognize these.
51+
If you read the section on components, you'll probably recognize these.
5252
They're properties that are decorated with the `@tracked` decorator:
5353

5454
```js

0 commit comments

Comments
 (0)