Skip to content

Commit 858f0c7

Browse files
authored
Merge pull request ember-learn#632 from ember-learn/jet-fuel
Fix failing links, markdown linting, and spelling errors
2 parents 7bd0e52 + b04d034 commit 858f0c7

33 files changed

+125
-132
lines changed

.local.dic

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
30KB
22
accessor
3+
accessors
4+
Accessors
35
activations
46
acyclic
57
ActiveSupport
@@ -8,6 +10,7 @@ Americentric
810
assistive
911
asynchrony
1012
autocomplete
13+
autotrack
1114
auto-rollup
1215
autoruns
1316
backend
@@ -19,11 +22,15 @@ breakpoint
1922
Browserlist
2023
camelize
2124
chainable
25+
cheatsheet
2226
Checkboxes
2327
checkboxes
2428
CoffeeScript
2529
componentized
30+
composable
2631
Ctrl-C
32+
customizable
33+
Customizable
2734
customizations
2835
D3
2936
dasherize
@@ -49,11 +56,15 @@ Evented
4956
facto
5057
falsy
5158
focusable
59+
foundational
5260
frontend
5361
fullname
5462
geocode
5563
geocoding
5664
Geolocation
65+
getter
66+
getters
67+
Getters
5768
globbing
5869
*google
5970
HammerJS
@@ -69,9 +80,11 @@ Inflector
6980
instantiation
7081
jquery-integration
7182
keyCode
83+
KVO
7284
linters
7385
lookups
7486
Mapbox
87+
MDN
7588
mixin
7689
mixins
7790
modularity
@@ -85,16 +98,22 @@ param
8598
params
8699
PascalCased
87100
pipelining
101+
POJO
102+
POJOs
88103
Polymorphism
89104
polymorphism
90105
PR
91106
PRs
92107
preload
93108
prepend
109+
prepended
110+
presentational
111+
Presentational
94112
pre-transition
95113
readme
96114
readonly
97115
recognizers
116+
Redux
98117
relayout
99118
repo
100119
rerender
@@ -109,24 +128,35 @@ serializers
109128
singularize
110129
SSR
111130
stateful
131+
subclasses
112132
subclassing
113133
subdomain
114134
subexpression
115135
suboptimal
116136
substate
117137
substates
138+
synergistically
118139
syntaxes
140+
tagless
119141
TalkBack
120142
teardown
121143
templating
122144
todo
123145
todos
146+
tooltip
147+
trackable
148+
Trackable
149+
Treeshaking
150+
truthy
124151
typeahead
125152
UIs
126153
unsilence
127154
untrusted
128155
usecase
129156
viewport
157+
VM
130158
VoiceOver
131159
WAI-ARIA
132160
WCAG
161+
websocket
162+
Websockets
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Coming soon!
1+
Coming soon!

guides/release/components/actions-and-events.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ confirmation that will show conditionally based on its `showConfirmation`
5454
property. You'll notice this property is decorated with the `@tracked`
5555
decorator - this is known as a _tracked property_, and indicates to Ember that
5656
the field will change in value over time. We'll discuss this more in the section
57-
on [State Management](../../state-management).
57+
on [State Management](../../state-management/).
5858

5959
Next, we need to hook up the button to toggle that property. We'll
6060
do this with an _action_:
@@ -168,7 +168,7 @@ then confirms. In the first case, we'll find the user's account and delete it.
168168

169169
We'll implement an action on the parent component called
170170
`userDidDeleteAccount()` that, when called, gets a hypothetical `login`
171-
[service](../../applications/services/) and calls the service's `deleteUser()`
171+
[service](../../services/) and calls the service's `deleteUser()`
172172
method. We'll go over services later on - for now, think of it as an API
173173
that manages the user's login and information.
174174

guides/release/components/arguments-and-attributes.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ standard identifier can:
6464
```
6565

6666
You can pass strings as arguments to components, or you can pass literal values
67-
using double curlies:
67+
using double curly brackets:
6868

6969
```handlebars
7070
<Tooltip
@@ -74,7 +74,7 @@ using double curlies:
7474
/>
7575
```
7676

77-
Note that if you do _not_ wrap literal values in double curlies, they are
77+
Note that if you do _not_ wrap literal values in double curly brackets, they are
7878
treated as strings, like standard HTML attributes:
7979

8080
```handlebars
@@ -216,7 +216,7 @@ not be applied.
216216

217217
The positioning of `...attributes` matters, with respect to the other attributes
218218
in the element it is applied to. Attributes that come _before_ `...attributes`
219-
can be overriden, but attributes that come _after_ cannot:
219+
can be overridden, but attributes that come _after_ cannot:
220220

221221
```handlebars
222222
<p

guides/release/components/component-basics.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
Components are an essential building block in Ember applications. They allow
2-
developers to package presentation and behaviour into a single unit and give it
2+
developers to package presentation and behavior into a single unit and give it
33
a name. You can think of them like defining your own custom HTML elements, like
44
a custom `<input>` or `<select>` tag that has its own behavior, values, and
55
events that you can hook into in your templates. However, they shouldn't be
66
confused with [_web components_](https://www.webcomponents.org/), which are a
77
browser based API that is similar, but not as powerful as Ember components.
88

9-
Like we mentioned in the section on [Templates](../../templates/), components
9+
Like we mentioned in the section on [Templates](../../templates/handlebars-basics/), components
1010
can have both a template and a class definition, like so:
1111

1212
```handlebars {data-filename=app/templates/components/hello-button.hbs}
@@ -92,9 +92,9 @@ component template:
9292
This allows you to have some logic in your templates, and to nest components
9393
within each other, building up a component _tree_. The component tree in Ember
9494
applications is similar to the DOM tree in the HTML - in fact, you can even
95-
inspect it using the Ember Inspector:
95+
inspect it using the [Ember Inspector](../../ember-inspector/).
9696

97-
[TODO: Screenshot of the Component tree in the Ember Inspector]
97+
<!-- [TODO: Screenshot of the Component tree in the Ember Inspector] -->
9898

9999
Components can also have blocks and children, just like standard HTML elements.
100100
We could update the `HelloButton` component to render its button text from its

guides/release/components/defining-a-component.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ will be covered later on in the guides.
7676
### Component Templates
7777

7878
Templates in components use the Handlebars templating language, as discussed in
79-
the [Templating](../../templating) section. A component's template is the layout
79+
the [Templating](../../templates/handlebars-basics/) section. A component's template is the layout
8080
that is used when rendering the component. If we update the `BlogPost`'s
8181
template to be:
8282

@@ -127,7 +127,7 @@ Here, we have two different kinds of dynamic values:
127127
```
128128

129129
We'll talk more about arguments in [the next
130-
section](../arguments-and-attributes). All arguments are prefixed with the `@`
130+
section](../arguments-and-attributes/). All arguments are prefixed with the `@`
131131
symbol, so whenever you see `{{@...` you know its referring to any argument.
132132

133133
- `{{this.sectionClass}}` refers to a _property_ of the component _instance_.
@@ -148,9 +148,10 @@ class property for title or post content:
148148
</section>
149149
```
150150

151-
Both arguments and properties can be used in any valid binding location (for
152-
more details on where and how you can bind values, read through the [section on
153-
templating](../../templating)). The reason you would choose an argument or
151+
Both arguments and properties can be used in any valid binding location. For
152+
more details on where and how you can bind values, read through the
153+
[section on templating](../../templates/handlebars-basics/).
154+
The reason you would choose an argument or
154155
property is based on how you expect to use the component, and whether or not the
155156
value should be based on internal logic within the component, or values passed
156157
to the component where it is used.
@@ -179,7 +180,7 @@ templates, and to nest components within each other, building up a component
179180
_tree_.
180181

181182
Finally, component templates can use a special helper: `{{yield}}`. We'll cover
182-
this helper in more detail in the [Yields](../yields) section later on, but this
183+
this helper in more detail in the [Yields](../yields/) section later on, but this
183184
helper allows us to specify that users can pass the component a _block_ of
184185
children, and where those children should be placed. If we go back to our
185186
`BlogPost` component, we can add a yield like this:
@@ -233,7 +234,7 @@ placed on any HTML element or component within the component's template:
233234
```
234235

235236
We'll talk more about attributes in [the next
236-
section](../arguments-and-attributes). They are values that get applied directly
237+
section](../arguments-and-attributes/). They are values that get applied directly
237238
to elements, and can be used to customize the HTML of a component. Unlike
238239
arguments, they are _not_ prefixed with the `@` symbol:
239240

guides/release/components/displaying-data.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ And to use a named argument you prefix it with `@`, like so:
1717
Since properties and named arguments are visually different,
1818
this syntax allows you to know where a value comes from when you are reading the template.
1919
If you encounter the `{{this.name}}` syntax,
20-
you know you should check the the JavaScript file of the component.
20+
you know you should check the JavaScript file of the component.
2121
If you encounter the `{{@friend}}` syntax,
2222
you know that the value is passed to the component when it is used in another template.
2323

@@ -26,7 +26,7 @@ you know that the value is passed to the component when it is used in another te
2626
To display a component property in the template, you prefix it with `this`,
2727
like you would in JavaScript.
2828

29-
For the example, we will build a `Greeting` component with an hard-coded name.
29+
For the example, we will build a `Greeting` component with a hard-coded name.
3030
Then, we will use that property in the component template:
3131

3232
```javascript {data-filename=src/ui/components/greeting/component.js}
@@ -96,4 +96,4 @@ The output will be:
9696
<p>Hello Zoey, I'm Tomster!</p>
9797
```
9898

99-
For more detailed information see [Passing arguments and HTML attributes](./passing-arguments-and-html-attributes).
99+
For more detailed information see [Passing arguments and HTML attributes](./arguments-and-attributes).

guides/release/components/glimmer-components-dom.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
For the most part, you should be be able to build Ember applications without directly manipulating the DOM. Before considering directly accessing the DOM, it's always best to first consider whether there's an Ember-native way to accomplish your goal.
1+
For the most part, you should be able to build Ember applications without directly manipulating the DOM. Before considering directly accessing the DOM, it's always best to first consider whether there's an Ember-native way to accomplish your goal.
22

33
## Thinking About Updates
44

@@ -159,7 +159,7 @@ export default class Counter extends Component {
159159
<div class="cta-note-body">
160160
<div class="cta-note-heading">Tomster says...</div>
161161
<div class="cta-note-message">
162-
"Element modifiers" appear inside free-floating curlies inside of an opening
162+
"Element modifiers" appear inside free-floating curly brackets inside of an opening
163163
tag. Unlike <strong>attribute syntax</strong>, which works by substitution
164164
(and therefore affects the HTML output of your page), element modifiers work
165165
by passing the element to a function that can do anything with it.

guides/release/components/wrapping-content-in-a-component.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ Now, we can use the `<BlogPost />` component and pass it properties in another t
1313
<BlogPost @title={{this.title}} @body={{this.body}} />
1414
```
1515

16-
See [Passing Properties to a Component](../passing-arguments-and-html-attributes/) for more.
16+
See
17+
[Passing Properties to a Component](../arguments-and-attributes/)
18+
for more.
1719

1820
In this case, the content we wanted to display came from the model.
1921
But what if we want the developer using our component to be able to provide custom HTML content?

guides/release/controllers/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export default Controller.extend({
7171
});
7272
```
7373

74-
The property `isExpanded` keeps track if the user has expanded the body or not. The action `toggleBody()` provides a way for the user to provide their setting. Both of the them are used in the updated template below.
74+
The property `isExpanded` keeps track if the user has expanded the body or not. The action `toggleBody()` provides a way for the user to provide their setting. Both of them are used in the updated template below.
7575

7676
```handlebars {data-filename=app/templates/blog-post.hbs}
7777
<h1>{{this.model.title}}</h1>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Coming soon!
1+
Coming soon!

guides/release/deploying/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Coming soon!
1+
Coming soon!

guides/release/getting-started/core-concepts.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ In Ember, we use the term **hook** for methods that are automatically called wit
6666

6767
Some examples of a hook are:
6868

69-
* [Component Lifecycle Hooks](../../components/the-component-lifecycle/): the [`willRender()`](https://emberjs.com/api/ember/release/classes/Component/methods/willRender?anchor=willRender/) hook gets called before each time a component renders
69+
* [Component Lifecycle Hooks](../../components/glimmer-components-dom/): the [`willRender()`](https://emberjs.com/api/ember/release/classes/Component/methods/willRender?anchor=willRender/) hook gets called before each time a component renders
7070
* Route Hooks: the [`model()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/model?anchor=model/) hook is used to load the model on a route
7171

7272
In the following example, the [`didRender()`](https://emberjs.com/api/ember/release/classes/Component/methods?anchor=didRender/) component lifecycle hook is used to log "I rendered!" to the console after each time the component is rendered.

guides/release/pages.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@
109109
- title: "Services"
110110
url: "services"
111111
pages:
112-
- title: Introduction
113-
url: "services"
114-
112+
- title: Overview
113+
url: "index"
114+
115115
- title: 'Data Management'
116116
url: 'data-management'
117117
pages:

guides/release/reference/syntax-conversion-guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ In the following example, `"greeting"` and `"name"` are positional parameters:
6161
{{my-greeting "Hello" "World"}}
6262
```
6363

64-
As shown in the relevant ["Position Params"](../../components/passing-arguments-and-html-attributes/#toc_positional-params) part of the Guides,
64+
As shown in the relevant ["Position Params"](../../components/arguments-and-attributes/#toc_positional-params) part of the Guides,
6565
there are two ways to handle them inside the component.
6666
One way is to individually specify what component property the positional parameter should map to.
6767
The other way is to map all positional parameters to the `params` property and refer to them by their index.

guides/release/routing/redirection.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ See [Storing and Retrying a Transition](../preventing-and-retrying-transitions/#
4949
for how to do that.
5050

5151
If you need to examine some application state to figure out where to redirect,
52-
you might use a [service](../../applications/services/).
52+
you might use a [service](../../services/).
5353

5454
## Transitioning After the Model is Known
5555

0 commit comments

Comments
 (0)