Skip to content

Commit e9ac235

Browse files
author
Jen Weber
authored
Merge pull request ember-learn#331 from ember-learn/forward-to-3-6
Port to v3.6, take 2
2 parents 7944226 + 198ba12 commit e9ac235

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

guides/v3.6.0/controllers/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,11 @@ We can see that if the property `isExpanded` is toggled to true, we will show th
9696

9797
### Common questions
9898

99-
###### Should we use controllers in my application? I've heard they're going away!
99+
#### Should we use controllers in my application? I've heard they're going away!
100100

101101
Yes! Controllers are still an integral part of an Ember application architecture, and generated by the framework even if you don't declare a Controller module explicitly.
102102

103-
###### When should we create a Controller?
103+
#### When should we create a Controller?
104104

105105
* We want to pass down actions or variables to share with a Route’s child components
106106
* We have a computed property that depends on the results of the model hook

guides/v3.6.0/testing/testing-components.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ external action is called:
247247
```javascript {data-filename="tests/integration/components/comment-form-test.js"}
248248
import { module, test } from 'qunit';
249249
import { setupRenderingTest } from 'ember-qunit';
250-
import { fillIn, render } from '@ember/test-helpers';
250+
import { click, fillIn, render } from '@ember/test-helpers';
251251
import hbs from 'htmlbars-inline-precompile';
252252

253253
module('Integration | Component | comment form', function(hooks) {
@@ -445,7 +445,7 @@ module('Integration | Component | location indicator', function(hooks) {
445445
### Waiting on Asynchronous Behavior
446446

447447
Often, interacting with a component will cause asynchronous behavior to occur, such as HTTP requests, or timers.
448-
The module `@ember/test-helpers` provides you with several [useful helpers](https://github.com/emberjs/ember-test-helpers/blob/master/API.md) that will allow you to wait for any asynchronous behavior to complete that is triggered by a DOM interaction induced by those.
448+
The module `@ember/test-helpers` provides you with several [useful helpers](https://github.com/emberjs/ember-test-helpers/blob/master/API.md) that will allow you to wait for any asynchronous behavior to complete that is triggered by a DOM interaction induced by those.
449449
To use them in your tests, you can `await` any of them to make sure that subsequent assertions are executed once the asynchronous behavior has fully settled:
450450

451451
```javascript

0 commit comments

Comments
 (0)