Skip to content

Commit edfb50c

Browse files
jason-maierjenweber
authored andcommitted
Minor grammatical changes (ember-learn#623)
1 parent 096f85c commit edfb50c

File tree

1 file changed

+17
-16
lines changed

1 file changed

+17
-16
lines changed

guides/v3.7.0/contributing/adding-new-features.md

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
In general, new feature development should be done on master.
22

3-
Bugfixes should not introduce new APIs or break existing APIs, and do
3+
Bug fixes should not introduce new APIs or break existing APIs, and do
44
not need feature flags.
55

66
Features can introduce new APIs, and need feature flags. They should not
@@ -15,13 +15,13 @@ possible.
1515

1616
#### Urgent Bug Fixes
1717

18-
Urgent bugfixes are bugfixes that need to be applied to the existing
18+
Urgent bug fixes are bug fixes that need to be applied to the existing
1919
release branch. If possible, they should be made on master and prefixed
2020
with `[BUGFIX release]`.
2121

2222
#### Beta Bug Fixes
2323

24-
Beta bugfixes are bugfixes that need to be applied to the beta branch.
24+
Beta bug fixes are bug fixes that need to be applied to the beta branch.
2525
If possible, they should be made on master and tagged with `[BUGFIX
2626
beta]`.
2727

@@ -37,7 +37,7 @@ Features must always be wrapped in a feature flag. Tests for the feature
3737
must also be wrapped in a feature flag.
3838

3939
Because the build-tools will process feature-flags, flags must use
40-
precisely this format. We are choosing conditionals rather than a block
40+
this exact format. We are choosing conditionals rather than a block
4141
form because functions change the surrounding scope and may introduce
4242
problems with early return.
4343

@@ -52,14 +52,15 @@ for the feature are passing against the current state of the feature.
5252

5353
#### Commits
5454

55-
Commits related to a specific feature should include a prefix like
55+
Commits related to a specific feature should include a prefix like
5656
`[FEATURE htmlbars]`. This will allow us to quickly identify all commits
57-
for a specific feature in the future. Features will never be applied to
58-
beta or release branches. Once a beta or release branch has been cut, it
59-
contains all of the new features it will ever have.
57+
for a specific feature in the future.
58+
59+
Features will never be applied to beta or release branches. Once a beta or
60+
release branch has been cut, no new features may be added.
6061

6162
If a feature has made it into beta or release, and you make a commit to
62-
master that fixes a bug in the feature, treat it like a bugfix as
63+
master that fixes a bug in the feature, treat it like a bug fix as
6364
described above.
6465

6566
#### Feature Naming Conventions
@@ -72,7 +73,7 @@ Ember.FEATURES['htmlbars']
7273

7374
### Builds
7475

75-
The Canary build, which is based off master, will include all features,
76+
The Canary build, which is based off master, will include all features
7677
guarded by the conditionals in the original source. This means that
7778
users of the canary build can enable whatever features they want by
7879
enabling them before creating their Ember.Application.
@@ -91,8 +92,8 @@ module.exports = function(environment) {
9192

9293
### `features.json`
9394

94-
The root of the repository will contain a `features.json` file, which will
95-
contain a list of features that should be enabled for beta or release
95+
The root of the repository will contain a `features.json` file, which
96+
contains a list of features that should be enabled for beta or release
9697
builds.
9798

9899
This file is populated when branching, and may not gain additional
@@ -104,8 +105,8 @@ features after the original branch. It may remove features.
104105
}
105106
```
106107

107-
The build process will remove any features not included in the list, and
108-
remove the conditionals for features in the list.
108+
The build process will remove any features not included in the list as well as
109+
conditionals for features in the list.
109110

110111
### Travis Testing
111112

@@ -137,7 +138,7 @@ Every six weeks, the core team goes through the following process.
137138
#### Beta Branch
138139

139140
All remaining features on the beta branch are vetted for readiness. If
140-
any feature isn't ready, it is removed from `features.json`.
141+
a feature isn't ready, it is removed from `features.json`.
141142

142143
Once this is done, the beta branch is tagged and merged into release.
143144

@@ -160,4 +161,4 @@ Every week, we repeat the Go/No-Go process for the features that remain
160161
on the beta branch. Any feature that has become unready is removed from
161162
the `features.json`.
162163

163-
Once this is done, a Beta release is tagged and pushed.
164+
Once this is done, a Beta release is tagged and pushed.

0 commit comments

Comments
 (0)