Skip to content

Commit 2b17868

Browse files
ashermancinelliGeorgeARM
authored andcommitted
[flang] Remove dead functions for getting LLVM intrinsics (llvm#137743)
In cleaning up LowLevelIntrinsics I found some uncalled functions. We would like to remove direct calls to llvm instructions wherever possible to make it easier on consumers of our IR to match LLVM intrinsics, so if this code is needed again we should use the op from the llvm dialect instead anyways.
1 parent 3e6acd2 commit 2b17868

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

flang/include/flang/Optimizer/Builder/LowLevelIntrinsics.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ class FirOpBuilder;
2424

2525
namespace fir::factory {
2626

27-
/// Get the LLVM intrinsic for `memset`. Use the 64 bit version.
28-
mlir::func::FuncOp getLlvmMemset(FirOpBuilder &builder);
29-
3027
/// Get the C standard library `realloc` function.
3128
mlir::func::FuncOp getRealloc(FirOpBuilder &builder);
3229

flang/lib/Optimizer/Builder/LowLevelIntrinsics.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,6 @@
2121
#include "flang/Optimizer/Builder/LowLevelIntrinsics.h"
2222
#include "flang/Optimizer/Builder/FIRBuilder.h"
2323

24-
mlir::func::FuncOp fir::factory::getLlvmMemset(fir::FirOpBuilder &builder) {
25-
auto ptrTy = builder.getRefType(builder.getIntegerType(8));
26-
llvm::SmallVector<mlir::Type> args = {ptrTy, ptrTy, builder.getI64Type(),
27-
builder.getI1Type()};
28-
auto memsetTy =
29-
mlir::FunctionType::get(builder.getContext(), args, std::nullopt);
30-
return builder.createFunction(builder.getUnknownLoc(),
31-
"llvm.memset.p0.p0.i64", memsetTy);
32-
}
33-
3424
mlir::func::FuncOp fir::factory::getRealloc(fir::FirOpBuilder &builder) {
3525
auto ptrTy = builder.getRefType(builder.getIntegerType(8));
3626
llvm::SmallVector<mlir::Type> args = {ptrTy, builder.getI64Type()};

0 commit comments

Comments
 (0)