Add todos for constant autoloading lookups

Author: Girgias

Zend/zend_builtin_functions.c

@@ -523,6 +523,7 @@ ZEND_FUNCTION(define)
 
 /* {{{ Check whether a constant exists
    Warning: This function is special-cased by zend_compile.c and so is usually bypassed */
+   // TODO Update this and compiler
 ZEND_FUNCTION(defined)
 {
 	zend_string *name;

Zend/zend_constants.c

@@ -276,6 +276,7 @@ ZEND_API bool zend_verify_const_access(zend_class_constant *c, zend_class_entry
 }
 /* }}} */
 
+// TODO Add support for auto-loading?
 static zend_constant *zend_get_constant_str_impl(const char *name, size_t name_len)
 {
 	zend_constant *c = zend_hash_str_find_ptr(EG(zend_constants), name, name_len);
@@ -302,6 +303,7 @@ ZEND_API zval *zend_get_constant_str(const char *name, size_t name_len)
 
 static zend_constant *zend_get_constant_impl(zend_string *name)
 {
+	// TODO Use lookup
 	zend_constant *c = zend_hash_find_ptr(EG(zend_constants), name);
 	if (c) {
 		return c;

Zend/zend_execute.c

@@ -4599,6 +4599,7 @@ static zend_always_inline zend_result _zend_quick_get_constant(
 	zend_constant *c = NULL;
 
 	/* null/true/false are resolved during compilation, so don't check for them here. */
+	// TODO Create a constant_lookup
 	zv = zend_hash_find_known_hash(EG(zend_constants), Z_STR_P(key));
 	if (zv) {
 		c = (zend_constant*)Z_PTR_P(zv);

Zend/zend_vm_def.h

@@ -5839,6 +5839,7 @@ ZEND_VM_HOT_HANDLER(99, ZEND_FETCH_CONSTANT, UNUSED|CONST_FETCH, CONST, CACHE_SL
 	}
 
 	SAVE_OPLINE();
+	// TODO Constant lookup
 	zend_quick_get_constant(RT_CONSTANT(opline, opline->op2) + 1, opline->op1.num OPLINE_CC EXECUTE_DATA_CC);
 	ZEND_VM_NEXT_OPCODE_CHECK_EXCEPTION();
 }

Zend/zend_vm_execute.h

@@ -33226,6 +33226,7 @@ static ZEND_VM_HOT ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_FETCH_CONSTANT_SPE
 	}
 
 	SAVE_OPLINE();
+	// TODO Constant lookup
 	zend_quick_get_constant(RT_CONSTANT(opline, opline->op2) + 1, opline->op1.num OPLINE_CC EXECUTE_DATA_CC);
 	ZEND_VM_NEXT_OPCODE_CHECK_EXCEPTION();
 }