Refactor getFullyQualifiedName in C#

Alvaro Muñoz · GeekMasher · commit 899c294d625d · 2024-05-31T18:32:55.000+01:00
diff --git a/csharp/src/library_sources/ExternalAPIsQuery.qll b/csharp/src/library_sources/ExternalAPIsQuery.qll
@@ -37,7 +37,10 @@ private class DefaultSafeExternalApiCallable extends SafeExternalApiCallable {
     this = any(SystemStringClass s).getIsNullOrWhiteSpaceMethod() or
     this.getName().regexpMatch("Count|get_Count|get_Length") or
     // SECLAB: Exclude all .NET methods
-    this.getDeclaringType().getFullyQualifiedName().matches(["System.%", "Microsoft.%", "Azure.%"])
+    this.getDeclaringType()
+        .getNamespace()
+        .getFullName()
+        .matches(["System.%", "Microsoft.%", "Azure.%"])
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,10 @@ private class DefaultSafeExternalApiCallable extends SafeExternalApiCallable {`
`37`	`37`	`this = any(SystemStringClass s).getIsNullOrWhiteSpaceMethod() or`
`38`	`38`	`this.getName().regexpMatch("Count\|get_Count\|get_Length") or`
`39`	`39`	`// SECLAB: Exclude all .NET methods`
`40`		`- this.getDeclaringType().getFullyQualifiedName().matches(["System.%", "Microsoft.%", "Azure.%"])`
	`40`	`+ this.getDeclaringType()`
	`41`	`+ .getNamespace()`
	`42`	`+ .getFullName()`
	`43`	`+ .matches(["System.%", "Microsoft.%", "Azure.%"])`
`41`	`44`	`}`
`42`	`45`	`}`
`43`	`46`